Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

fix vvisp utils #94

Closed
wants to merge 4 commits into from
Closed

fix vvisp utils #94

wants to merge 4 commits into from

Conversation

JhChoy
Copy link
Contributor

@JhChoy JhChoy commented Feb 25, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

#93 should be merged first!

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

  • vvisp-utils/getConfigRoot was async function
  • privateKey was fixed to 12 words

What is the new behavior?

  • vvisp-utils now exports compilerSupplier and filterPrivateKey
  • vvisp-utils/getConfigRoot changes to sync function
  • privateKey has no more words length limitation

Does this PR introduce a breaking change?

  • Yes
  • No

@JhChoy JhChoy added bug Something isn't working enhancement New feature or request utils About vvisp-utils labels Feb 25, 2019
@JhChoy JhChoy self-assigned this Feb 25, 2019
@JhChoy JhChoy mentioned this pull request Feb 25, 2019
14 tasks
@JhChoy
Copy link
Contributor Author

JhChoy commented Feb 27, 2019

It should be merged to 1.0.0 and is duplicated with #101

@JhChoy JhChoy closed this Feb 27, 2019
@JhChoy JhChoy added the duplicate This issue or pull request already exists label Feb 27, 2019
@JhChoy JhChoy deleted the jay/fix-vvisp-utils branch February 27, 2019 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working duplicate This issue or pull request already exists enhancement New feature or request utils About vvisp-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants