Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Jay/make config file #95

Closed
wants to merge 6 commits into from
Closed

Jay/make config file #95

wants to merge 6 commits into from

Conversation

JhChoy
Copy link
Contributor

@JhChoy JhChoy commented Feb 25, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

#94 should be merged first

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #24

What is the new behavior?

vvisp-utils/Config now added

Does this PR introduce a breaking change?

  • Yes
  • No

@JhChoy JhChoy added enhancement New feature or request utils About vvisp-utils labels Feb 25, 2019
@JhChoy JhChoy added this to the vvisp v1.0.0 milestone Feb 25, 2019
@JhChoy JhChoy self-assigned this Feb 25, 2019
cloudinertia
cloudinertia reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@cloudinertia cloudinertia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커멘트 달았습니다!

packages/vvisp-utils/src/Config.js Show resolved Hide resolved
packages/vvisp-utils/test/ci.sh Show resolved Hide resolved
packages/vvisp/test/ci.sh Show resolved Hide resolved
@JhChoy JhChoy added the duplicate This issue or pull request already exists label Feb 27, 2019
@JhChoy
Copy link
Contributor Author

JhChoy commented Feb 27, 2019

It should be merged to 1.0.0 and is duplicated with #101

@JhChoy JhChoy closed this Feb 27, 2019
@JhChoy JhChoy deleted the jay/make-Config-file branch February 27, 2019 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cloudinertia cloudinertia cloudinertia left review comments

@Nipol Nipol Nipol approved these changes

@leekt leekt leekt approved these changes

@zero1ne zero1ne Awaiting requested review from zero1ne

@junbeomlee junbeomlee Awaiting requested review from junbeomlee

Assignees

@JhChoy JhChoy

Labels
duplicate This issue or pull request already exists enhancement New feature or request utils About vvisp-utils
Projects
None yet
Milestone
vvisp v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JhChoy @Nipol @cloudinertia @leekt