Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Jay/make web3 store file #96

Closed
wants to merge 7 commits into from
Closed

Jay/make web3 store file #96

wants to merge 7 commits into from

Conversation

JhChoy
Copy link
Contributor

@JhChoy JhChoy commented Feb 25, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

vvisp-utils/getWeb3 use dotenv

What is the new behavior?

  • getWeb3 => web3Store
  • Remove dependency of dotenv
    web3Store has 3 functions
  1. setWithProvider: set web3 with provider
  2. setWithURL: set web3 with http url
  3. get: getter of stored web3, if there isn't, return void web3
  4. delete: delete stored web3 for test

Does this PR introduce a breaking change?

  • Yes
  • No

@JhChoy JhChoy added enhancement New feature or request utils About vvisp-utils labels Feb 25, 2019
@JhChoy JhChoy added this to the vvisp v1.0.0 milestone Feb 25, 2019
@JhChoy JhChoy self-assigned this Feb 25, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 383

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-24.6%) to 62.485%

Files with Coverage Reduction New Missed Lines %
src/sendTx.js 1 91.18%
src/getPrivateKey.js 2 84.62%
Totals Coverage Status
Change from base Build 368: -24.6%
Covered Lines: 385
Relevant Lines: 595

💛 - Coveralls

@JhChoy JhChoy mentioned this pull request Feb 25, 2019
14 tasks
This was referenced Feb 27, 2019
@JhChoy JhChoy added the duplicate This issue or pull request already exists label Feb 27, 2019
@JhChoy
Copy link
Contributor Author

JhChoy commented Feb 27, 2019

duplicated with #101

@JhChoy JhChoy closed this Feb 27, 2019
@JhChoy JhChoy deleted the jay/make-web3Store-file branch February 27, 2019 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists enhancement New feature or request utils About vvisp-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants