Clean-Up And Delete Unused Icons...

[RebeccaDeField]

We need to delete the icons that are no longer in use. I know that the Freeze icon is no longer being used, but I'm asumming there are several others that are still in the icons folder.

These have not been deleted already, I'm not sure if there is a reason why, so I didn't want to go ahead and start deleting things. If there is not a reason for this, then I just need to know the names of the icons that I no longer being used so that I can delete them.

I've @mentioned the coders that have volunteered to assist with coding for this theme. I know you're all busy, but if you have time, I would really appreciate some assistance on this.

@Umcaruje
@tresf
@diizy
@Sti2nd

[tresf]

I didn't want to go ahead and start deleting things

Please go ahead and start deleting things that are known to not be in use. Leftover cruft is a mistake. 👍

In regards to coding, @Sti2nd and @diizy haven't been extremely active lately and myself and @Umcaruje are quite busy, so it may take some time for some of these items.

Last, I really don't like doing this on @HDDigitizerMusic's repo. He left the project high and dry on several items and I have no sense of trust working from this location.

[RebeccaDeField]

@tresf I understand you guys are busy, so no pressure. I just wanted to get these in front of the people that want to help so that you can when you have time.

As for working with Digitizer, it's too bad that you feel that way. I have been working very closely with him the whole time. He has made huge contributions to this theme, he was the one who came up with the idea in the first place, and I have worked with him on many other projects. I witnessed the way he was being treated by some of the users, which is why he chose to move on after he had finished the work that he had committed to.

I don't see how any problems could emerge with how things are setup. If anything, this can be a good opportunity to build some trust and mend bridges.

[tresf]

I witnessed the way he was being treated by some of the users, which is why he chose to move on after he had finished the work that he had committed to.

I'd rather not use the internet as a public location to stir up the past, but this is not personal. He didn't finish his work, so I'm not sure what that statement is in regards to. I won't beat the topic up further, but I wanted a full disclaimer that past items were never settled. It's your hard work and determination bringing us here, and we do so feeling a bit of unease.

[RebeccaDeField]

Since this is a separate project I agree that it would be best to keep the threads on topic.

I welcome anyone who is willing to contribute to this project, and as much as I would really love to get your help because of how skilled you are, if you don't like the way things are setup on this repo, it's completely your choice if you want contribute or not. That being said, I am not planning on changing the setup for this repo. I hope that we can move forward now, without any problems.

Of course, there are still many things I have left to do, but I am very excited with how far this has come. I have just recently committed a lot of updates to the artwork and more are coming. :)

[tresf]

👍

[tresf]

@RebeccaDeField here are my findings.

@michaelgregorius @Umcaruje @StakeoutPunch a spot-check is greatly appreciated.

Some special considerations:

• Some of these were tricky because they use counters or dynamic filenames such as knob01 and note_tripletquarter.
• Some pixmaps are only used for plugins and some are used by multiple plugins. It's arguable that they should be moved or cloned into their respective plugin locations, but the decision to completely decouple our internal plugins is a conversation for another day IMO.

Ok... here it is...

PIXMAP	IN-USE
add_automation	✅
add_bb_track	✅
add_folder	✅
add	✅
add_sample_track	✅
analysis	✅
apply	✅
Apply-selected	✅
arp_down	✅
arp_free	✅
arp_random	✅
arp_sort	✅
arp_sync	✅
arp_up_and_down	✅
arp_up	✅
automation	✅
automation_track	✅
autoscroll_off	✅
autoscroll_on	✅
background_artwork	✅
back_to_start	✅
back_to_zero	✅
bb_track_btn	✅
bb_track	✅
black_key	✅
black_key_pressed	✅
cancel	✅
chord	✅
clock	✅
colorize	✅
combobox_arrow	✅
combobox_arrow_selected	✅
combobox_bg	✅
computer	✅
controller	✅
cpuload_bg	✅
cpuload_leds	✅
dont_know	✅
drum	⛔
edit_copy	✅
edit_cut	✅
edit_draw	✅
edit_erase	✅
edit_move	✅
edit_paste	✅
edit_redo	✅
edit_rename	✅
edit_select	✅
edit_undo	✅
effect_plugin	✅
envelope_graph	✅
error	✅
exit	✅
exp_wave_active	✅
exp_wave_inactive	✅
factory_files	✅
fader_background	✅
fader_knob	✅
fader_leds	✅
filter_2lp	✅
filter_ap	✅
filter_bp	✅
filter_hp	✅
filter_lp	✅
filter_notch	✅
flip_x	✅
flip_y	✅
folder_locked	✅
folder_opened	✅
folder	✅
freeze	⛔
frozen	⛔
fx_mixer	✅
hand	✅
help	✅
hint	✅
home	✅
hq_mode	✅
icon	✅
instrument_track	✅
keep_stop_position	✅
knob01	✅
knob02	✅
knob03	✅
knob04	✅
knob05	✅
lcd_19green	✅
lcd_19red	✅
lcd_21pink	✅
led_green	✅
led_off	✅
led_red	✅
led_yellow	✅
lfo_controller_artwork	✅
lfo_d100_active	✅
lfo_d100_inactive	✅
lfo_graph	✅
lfo_x100_active	✅
lfo_x100_inactive	✅
lfo_x1_active	✅
lfo_x1_inactive	✅
loop_point_b	✅
loop_point_e	✅
loop_points_off	✅
loop_points_on	✅
main_slider	✅
master_pitch	✅
master_volume	✅
metronome	✅
midi_file	✅
mixer_send_off	✅
mixer_send_on	✅
moog_saw_wave_active	✅
moog_saw_wave_inactive	✅
muted	✅
new_channel	✅
note_double_whole	✅
note_eighth	✅
note_half	✅
note_none	✅
note	✅
note_quarter	✅
note_sixteenth	✅
note_thirtysecond	✅
note_tripleteighth	✅
note_triplethalf	✅
note_tripletquarter	✅
note_tripletsixteenth	✅
note_tripletthirtysecond	✅
note_whole	✅
output_graph	✅
pat_rec	✅
pause	✅
piano	✅
play	✅
playpos_marker	✅
plugins	✅
ports	✅
pr_black_key	✅
pr_black_key_pressed	✅
preset_file	✅
progression_cubic_hermite	✅
progression_discrete	✅
progression_linear	✅
project_export	✅
project_file	✅
project_import	✅
project_new_from_template	✅
project_new	✅
project_notes	✅
project_open_down	⛔
project_open	✅
project_open_recent	✅
project_saveas	✅
project_save	✅
pr_white_key_big	✅
pr_white_key_big_pressed	✅
pr_white_key_small	✅
pr_white_key_small_pressed	✅
quantize	✅
random_wave_active	✅
random_wave_inactive	✅
receive_bg_arrow	✅
record_accompany	✅
record	✅
reload	✅
round_square_wave_active	✅
round_square_wave_inactive	✅
sample_file	✅
sample_track	✅
saw_wave_active	✅
saw_wave_inactive	✅
sbarrow_down_d	✅
sbarrow_down	✅
sbarrow_left_d	✅
sbarrow_left	✅
sbarrow_right_d	✅
sbarrow_right	✅
sbarrow_up_d	✅
sbarrow_up	✅
scale	✅
send_bg_arrow	✅
setup_audio	✅
setup_directories	✅
setup_general	✅
setup_midi	✅
setup_performance	✅
sin_wave_active	✅
sin_wave_inactive	✅
songeditor	✅
soundfont_file	✅
splash	✅
square_wave_active	✅
square_wave_inactive	✅
step_btn_add	✅
step_btn_duplicate	✅
step_btn_off_light	✅
step_btn_off	✅
step_btn_on_100	✅
step_btn_on	⛔
step_btn_on_yellow	✅
step_btn_remove	✅
stepper-down	✅
stepper-down-press	⛔
stepper-left	✅
stepper-left-press	✅
stepper-right	✅
stepper-right-press	✅
stepper-up	✅
stepper-up-press	✅
stop	✅
tempo_sync	✅
text_block	✅
text_bold	✅
text_center	✅
text_italic	✅
text_left	✅
text_right	✅
text_under	✅
trackop_c	✅
track_op_grip	✅
trackop_h	✅
track_op_menu_active	✅
track_op_menu	✅
trackop	✅
triangle_wave_active	✅
triangle_wave_inactive	✅
uhoh	✅
unavailable_sound	✅
unfreeze	⛔
unknown_file	✅
usr_wave_active	✅
usr_wave_inactive	✅
vst_plugin_file	✅
whatsthis	✅
white_key	✅
white_key_pressed	✅
white_noise_wave_active	✅
white_noise_wave_inactive	✅
zoom	✅
zoom_x	✅
zoom_y	✅

[michaelgregorius]

Here is an overview of all the pixmaps that are marked as unused above:

Name	Icon
drum
freeze
frozen
project_open_down
step_btn_on
stepper-down-press
unfreeze

I think we should remove them in case no one identifies one or more of them as being used somewhere.

[RebeccaDeField]

Thank you for such comprehensive work! 👍

I will delete these on this fork. We should probably delete them from the default theme as well.

[tresf]

I will delete these on this fork. We should probably delete them from the default theme as well.

We can cherry-pick the commit once you've completed it, just file a bug upstream and we'll pull the changes in. Alternately we can do them manually, but it is important that a change like this makes it upstream. 👍

[Umcaruje]

I'm against removing the stepper-down-press icon, since if stepper-down is used somewhere, stepper-down-press should be used when that button is clicked.

[RebeccaDeField]

@Umcaruje I have no problem with keeping that one if you feel that it is important.