-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern And Sleek Theme For LMMS #880
Comments
I like the beat pattern as well - I wonder how this would look like scaled down to the image sizes we currently have. Maybe we could target this alternative theme for 2.0? |
On 06/23/2014 05:15 AM, Digitizer wrote:
We just did an upgrade of the theme for 1.0 and it's still getting
That's great. There's never too many themes. It's been discussed to
That's nice. Designing a GUI for a software is however a bit different
That's all a bit too large to be very convenient for LMMS. There's lots
Yeah, well, there's the thing - that beat pattern looks nice as a static GUI design for a complex software is not the same as designing a My suggestion to you is that you first try to make a complete theme for That said, those graphics do look nice, there's a very nice style to it, But seriously, like I said... your best bet is to start working on a
Why does she need guarantees that it'll be the new default theme? The default theme is not something you can just "drop off" like a kid to a daycare. It's not something we can outsource and be done with it. LMMS is, first and foremost, a collaborative open-source project, and the default theme is something that lives and grows with the software, it needs to be constantly maintained, and developed in tandem with new GUI features. Which is why it's something that has to be developed openly and collaboratively, with the LMMS team, so that we all have access to the development process and will be able to change things when necessary. |
Vesa worked hard on the current default theme 👍 And appearance isn't everything a theme is, but I would love to get my hands on a good looking theme like that! What we could do is to include two themes in LMMS, the one we have now and the one she will make. Do you think she will agree on this, @HDDigitizerMusic ? |
@Sti2nd Hi, I am the aforementioned graphic artist :) I agree that Vesa did a fantastic job on the theme he contributed! Because I use Inkscape you will absolutely be able to “get your hands on it” ;) I think that is a great idea! The more themes the better. |
We want to collaborate on this together. I think that the changes and updates that you have already made are very awesome and I agree that we don’t need to replace the theme any time soon as the default theme is something that should constantly be worked on and improved. I do think that we always have room to grow and collaborate. Like you said there is no reason to stop improving the theme.
I would like it if we could help to contribute to the default theme, but if that is not possible then she will be more than willing to create an alternative. I think that your idea of adding a feature that will allow people to select different themes within the interface is awesome. This will help the other graphic artists who want to contribute themes to LMMS as well.
She has experience and knowledge in GUI design and usability. She also has experience in open source programs specifically as she interned with the people who collaborated on the interface for Amarok, the KDE theme as a whole, and other various KDE projects. I agree with you about the functionality and usability, this is just a preview with larger graphics so you can see some of the finer details and we do not intend for the interface to be that big. We created this thread to collaborate on the theme so if you think that it should be less flashy or smaller we as a community can update it.
We agree that it is a bad idea to waste space just for the sake of fancy shines or glowing graphics and will create this theme with that in mind. There is something to be said about creating neat graphics that give the users a great experience, and I can see that you are thinking along the same lines because you have already included slick and creative elements in the theme that you created.
I have created many themes myself and understand how it works. If it would be most helpful for us to create an alternative theme, then she can do that.
I really appreciate all of the work you have contributed towards the current theme and am seeking to collaborate. Thank you for the offer, I’ll be sure to contact you for any questions we have.
What she meant was she had wanted everyone's feedback before we created the whole theme. That way we don’t end up creating a theme with a certain type of button or glow, that a majority of the community just doesn’t like. We were planning on creating an alternative theme anyway, so we will just start there.
I understand and agree. Not only have we based our theme on the work that you have already done, but she uses linux and inkscape for all of her designs, so she is completely willing to provide all of the .svg source files for all of her work so that you, and anyone else who wants to access adapt or improve on her work can. She understands how open source projects work and is not just outsourcing this. She wants to work as a contributor to the project just as you are. She is getting an account to reply and collaborate with all of you on this as well. Thank you for your time and detail in your reply, |
On 06/24/2014 03:20 AM, Rebecca DeField wrote:
Absolutely! And I think it's great that you're a graphic artist using |
On 06/24/2014 03:31 AM, Digitizer wrote:
Yes. At this point though... I think there aren't very much things that I'm sure we'll at some point go through a whole new theme revamp again, There's very little that can be done with the default theme right now, Only thing is, the theme engine of LMMS is currently a bit of a moving
Yeah. I'll amend my earlier statement a bit - I'd like to get these And if you're not in time for 1.1.0, then maybe we can add it in the
That's good to hear. I was mainly just saying all this because I wasn't
At this point, I think it would. Because it's always good to provide |
Also, if there are some theming capabilities that are still missing - Some caveats: Qt (or at least Qt4, not sure if they've improved this in Another thing - don't ask about the subwindow titlebars... Qt doesn't |
Vesa there could be some things that can be done. Why dont we give users On Tue, Jun 24, 2014 at 10:34 AM, Vesa V notifications@github.com wrote:
Jonathan Aquilina |
Luckily Rebecca agreed on making a theme in addition to the default theme, so we'll still get what seems would be a delicious alternative default theme for LMMS! @diizy Theming capabilities that are still missing: The new default knob, with the white dynamic circle. |
On 06/24/2014 07:11 PM, Stian Jørgensrud wrote:
You change the knob graphic by replacing the .png, and the line colour The "windowText" palette colour is used for the knob lines and arcs. |
Can i ask for new option for knobs and other colorful controls? |
@diizy Sounds great. I'll totally contact you when I need some coding help. I think we have all agreed on this becoming an alternative theme. |
On 06/24/2014 08:24 PM, Ra wrote:
Yeah, this isn't possible currently. Maybe in the future, we'd first have to get the knobs subclassed (like I |
Please keep me @tresf on copy of progress as it is made. I'm very interested in seeing progress on this and helping with the code where necessary. As far as being the new default theme, time can only tell. Coming from someone who's contributed a few items to the existing theme, I can speak on behalf of the tremendous amount of work this stuff takes. If you do indeed plan on sharing your Inkscape artwork with the team, please keep us posted as to how to access that. As Vesa has illustrated, there are many areas in the LMMS GUI where larger, smaller or re-positioned widgets require code changes due to the almost purely static layouts that have been used over the years. Since these don't play nicely with dynamically sized/positioned content something as simple as re-positioning an LED can be quite the daunting task, but please don't let that hinder progress. 😺 In any case, this topic has already stirred enough interest to validate it's merit. Once you get positioned with forking on GitHub, please link us your fork. You have many interested parties. :) |
On 06/24/2014 09:23 PM, Tres Finocchiaro wrote:
It's less an issue of static layouts, but rather the issue I mentioned Basically, right now I'm not even sure if we have any way of defining So for now, if we want to change these, then it has to be a change that |
I'm not suggesting that. What I'm referring to is -- more generically -- a layout that allows widgets to assume their natural size and some UI behavior that allows elements to flow into eachother as needed. All conceptually of course, but this is common in most graphical tool-kits. Here's a better explanation of what I'm referring to: QT acts as our GUI toolkit and actually does have some capabilities for this but from my research it is limited. To free the programmer (where appropriate) from hard-coding element positions could have some significant advantages including common concepts such as overflowing toolbars, content rearranging to window size, etc. Again, only where appropriate, but I believe could help theming in many areas. |
On 06/24/2014 10:28 PM, Tres Finocchiaro wrote:
Oh. Yeah, we already have that, like in the FX mixer where the size of Simple layout tricks like that are relatively easy, but when it comes to
Yeah, reorganizing/overflowing toolbars for eg. piano roll is on the |
short comment - a thought for users with sight problems, could/should also be in this scope. Vesa has mentioned color-blindness, but ..look aside from 'color', and you have a somewhat more problematic condition :D |
@HDDigitizerMusic @RebeccaDeField it's been a few weeks... how is progress going on this? 🐈 |
@tresf I have been pretty busy for the past week but I have worked on this in my free time and am making good progress. I will be posting some more detailed updates soon and if I have any questions I'll be sure to let you know :) |
@RebeccaDeField, thanks for sharing! I can't wait to see these in action. Let us know if you need any help from a code and/or testing perspective. |
Thank you for your feedback! I will definitely be contacting you if I have any questions. Once I get into the more major design elements there will be things I need help with. I'm more of a designer than a coder. |
Love the look as well cant wait to see them in play :) On Sun, Jul 20, 2014 at 7:54 AM, Rebecca DeField notifications@github.com
Jonathan Aquilina |
Totally waaant 😄 🍰 |
Yes. I like this. I tried making a similar theme a couple weeks ago but On Tue, Sep 2, 2014 at 2:32 PM, Rebecca DeField notifications@github.com
|
Looks good! Keep up the good work! :D |
I don't think this is the best place to discuss whether or not/how the BB
editor should stretch, and I don't really see an issue with it stretching
either.
|
Sorry Spekular, i saw something about the BB Editor stretching on this post, and a stretched icon isn't very good to see (for me)....however you're right, this isn't the right place, my fault👍 |
@SimoneIervasi @Spekular I think the issue is more that it gets pixelated when stretched. You can see some of the solutions and progress that has been made here HDDigitizerMusic#1 (comment) You're more than welcome to contribute to the conversation. |
Thanks Rebecca! |
That's beautiful! |
As you can see, things are coming along pretty nicely. I believe that it is very close to completion. I am almost done with all of the things on my list and I will be adding some new issues. I will also be making another big comit soon. As always, I will keep you updated and thank you for all of the support. :D |
This is shaping up nicely, thanks for sharing. |
@RebeccaDeField The theme looks quite nice! :D As a suggestion, the color contrast between the Sample Track segment and the black background could be bigger since it could be hard to discern the waveforms from the background. |
@RebeccaDeField Yes that is the section I was referring to. Thanks! |
I would switch to lmms if you implement @budislav one window concept. For now lmms seems to be ugly and hard to master. It seems archaic... |
Please continue to use another DAW, your feedback is not helpful in this thread. 👍 Edit: your last post has been deleted. you've already made your point if you continue to post garbage on our tracker you will be permanently banned |
I think that budislav's work is excellent, but it may take some time to implement. I am always excited to see progress on that side of things. This His theme and this theme are very different things with different uses, for different times. If anyone wants to help with the UI of LMMS just search for one of the many great themes that are being developed (cusis is another one) and start contributing. You can also make your own theme, now, more than ever with the changes that have been made recently. :) |
Closing as duplicate. Superseded by #2587. This thread has run it's course and now we're at a point where we can call this new theme "almost ready". Please feel free to continue specific discussion here. The replacement thread will be used to track the milestone of how to incorporate this theme into a future LMMS build. Thanks to all for all the hard work, feedback, etc. 👍 |
Quick question: Does anyone know what Knob04.png controls? |
@RebeccaDeField A quick search shows that it's not referred to by name anywhere in the LMMS codebase or the default theme. So it's most likely unused. |
Scratch that though, neither are any of the other knobs referred to by name. So LMMS is probably doing something clever and concatenating "Knob" with "03" (or "02", "01", maybe "04") at runtime, making it hard to search for. So I have no way of telling if it's used or not. |
@Wallacoloo No problem. Thanks for searching :) |
Seems like that knob is not used. The magical code that @Wallacoloo has prophesied correctly can be found here. For |
@RebeccaDeField Thank you for your reply. I understand that. And I hoping LMMS could get a proper desing. I'm crossing my fingers for that. @tresf I see that somebody got a butthurt because truth has been spoken. I'm from community where some guys uses LMMS (ex. Loco) - I'm ok with that. I also used it, and I wishing LMMS everything best. That I have say my opinion (like some of my friends on forum) is that worse? Don't look only by the programming way. Look how typical user see things. I'm done. |
I'm not sure what you're talking about specifically, but if you'd like to contact me personally/directly on this matter I can investigate. I'd much prefer we save the tracker from off-topic rants (or whatever is happening in your post). 👍 |
I have opened pull request #2644 which removes the unused knob 'knob04.png` and which also contains a proposal to rename the knob images so that they can be found better in the code. And now I will let this closed issue rest in peace. 😉 |
LMMS has excellent features and is becoming an awesome and reliable DAW. I think we can all agree, that the next step in improving LMMS is upgrading the theme to be more slick and clean to fit with the next version.
I know a graphic designer who is willing to contribute a new theme for LMMS for free. She works for a marketing agency who have worked with many commercial projects as a professional graphic artist.
I have worked collaboratively with her to showcase the style direction that we believe would bring LMMS to the next level. You can take a look at the preview below.
My favorite element has the be the beat pattern on the bottom. Its pretty cool how she incorporated the LMMS logo into it.
What do you think of it? Is this the right direction for a new theme? Please reply with your feedback and suggestions below. Once she get's the go ahead for this being used as the default theme in the new version, she will finish the full theme. She is also available to make changes to the style and direction once those changes have been agreed on.
The text was updated successfully, but these errors were encountered: