Jan ws changes #282
Merged
Jan ws changes #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
qkoziol
approved these changes
Jan 25, 2021
fortnern
reviewed
Jan 27, 2021
| @@ -1540,7 +1540,7 @@ H5S__get_select_elem_pointlist(const H5S_t *space, hsize_t startpoint, hsize_t n | |||
| startpoint--; | |||
| node = node->next; | |||
| } /* end while */ | |||
| } /* end else */ | |||
There was a problem hiding this comment.
I don't understand why the end else is being indented here
There was a problem hiding this comment.
Because we have alignment of comments on. There is no blank line between the two comments, so they are a single block for the formatter.
Personally, I think the indentation is even less important then the use of "end" comments on short blocks (is the "end while" really necessary?)
lrknox
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in H5Tprivate.h.
Whitespace changes in other files.