Merge PR #274 to 1.12 Branch #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from Canonical
…HDFGroup#270) * Cache the pointer to the next point to process after the last call to H5S__get_select_elem_pointlist. This allows the normal process of iterating over the points in batches to be much more efficient, as the library does not need to traverse the entirety of the preceding points every time the funciton is re-entered. * Update RELEASE.txt for point selection iteration performance fix.
…ype() (HDFGroup#274) * Fixed problems with vlens and refs inside compound using H5VLget_file_type() * Fix date in RELEASE.txt * Add assertions * Move some manipulation of H5VL_object_t struct fields into the H5VL package.
fortnern
requested review from
bljhdf,
byrnHDF,
derobins,
jhendersonHDF,
jrmainzer,
lrknox,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
|
I don't know why this PR is including the merge for #270 , which was already merged to hdf5_1_12 |
Improve performance of multiple calls to H5Sget_select_elem_pointlist…
|
Ok I think it's fixed now. |
byrnHDF
reviewed
Jan 25, 2021
|
So turns out a different mistake was the culprit - I forgot to "add" a fix to the original merge commit that was present in my working directory. I think it makes sense to just let the other issue be fixed when Allen's change is merged to 1.12 since it isn't breaking anything right now. |
lrknox
approved these changes
Jan 27, 2021
Yes, that has to be fixed in this PR because it doesn't exist yet for me to fix. |
|
You fixed it in PR #282 which has been merged to develop, but I guess not to hdf5_1_12?
From: Allen Byrne <notifications@github.com>
Sent: Wednesday, January 27, 2021 1:52 PM
To: HDFGroup/hdf5 <hdf5@noreply.github.com>
Cc: Larry Knox <lrknox@hdfgroup.org>; Review requested <review_requested@noreply.github.com>
Subject: Re: [HDFGroup/hdf5] Merge PR #274 to 1.12 Branch (#283)
Approved provided the correction to line 44 of H5Tprivate.h is preserved in hdf5_1_12.
Yes, that has to be fixed in this PR because it doesn't exist yet for me to fix.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCS5BNQBERHIN7SYHATS4BVHHANCNFSM4WSK22ZQ>.
|
lrknox
reviewed
Jan 27, 2021
|
I figured it would save Allen the headache of merge conflicts if I didn't fix it here, but it doesn't matter to me. |
|
He said it had to be in the PR because the line was new for 1_12 except for the PR.
It provided me an opportunity to try committing from a suggestion in the PR on github, which I’d noticed in the spack repo but hadn’t known how to do. For a minor change (1 missing character in this case) it was much easier than making a change in a clone and pushing it to the fork/branch.
From: Neil Fortner <notifications@github.com>
Sent: Wednesday, January 27, 2021 5:06 PM
To: HDFGroup/hdf5 <hdf5@noreply.github.com>
Cc: Larry Knox <lrknox@hdfgroup.org>; Review requested <review_requested@noreply.github.com>
Subject: Re: [HDFGroup/hdf5] Merge PR #274 to 1.12 Branch (#283)
I figured it would save Allen the headache of merge conflicts if I didn't fix it here, but it doesn't matter to me.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCXVUM7WGQL5NYZII6LS4CL5RANCNFSM4WSK22ZQ>.
|
|
So how did you do it, Larry?
…________________________________________
From: Larry Knox <notifications@github.com>
Sent: Wednesday, January 27, 2021 6:03 PM
To: HDFGroup/hdf5
Cc: Allen Byrne; Review requested
Subject: Re: [HDFGroup/hdf5] Merge PR #274 to 1.12 Branch (#283)
He said it had to be in the PR because the line was new for 1_12 except for the PR.
It provided me an opportunity to try committing from a suggestion in the PR on github, which I’d noticed in the spack repo but hadn’t known how to do. For a minor change (1 missing character in this case) it was much easier than making a change in a clone and pushing it to the fork/branch.
From: Neil Fortner <notifications@github.com>
Sent: Wednesday, January 27, 2021 5:06 PM
To: HDFGroup/hdf5 <hdf5@noreply.github.com>
Cc: Larry Knox <lrknox@hdfgroup.org>; Review requested <review_requested@noreply.github.com>
Subject: Re: [HDFGroup/hdf5] Merge PR #274 to 1.12 Branch (#283)
I figured it would save Allen the headache of merge conflicts if I didn't fix it here, but it doesn't matter to me.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCXVUM7WGQL5NYZII6LS4CL5RANCNFSM4WSK22ZQ>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL77KBT7AEOJIFXAKSF4LRDS4CSVBANCNFSM4WSK22ZQ>.
|
|
* Select line/lines of code and click ‘+’ for comment.
* Click “+/-“ (above “Leave a comment”, to right of “Preview”)
* Edit code in suggestion block
* “Add single comment” adds suggested change, which has a “commit” button. I think anyone who has permissions to commit to the branch that the PR is coming from would be able to commit the change. I assume also that “Start a review” instead of “Add single comment” would also add the suggestion.
From: Allen Byrne <notifications@github.com>
Sent: Thursday, January 28, 2021 6:53 AM
To: HDFGroup/hdf5 <hdf5@noreply.github.com>
Cc: Larry Knox <lrknox@hdfgroup.org>; State change <state_change@noreply.github.com>
Subject: Re: [HDFGroup/hdf5] Merge PR #274 to 1.12 Branch (#283)
So how did you do it, Larry?
…________________________________________
From: Larry Knox <notifications@github.com<mailto:notifications@github.com>>
Sent: Wednesday, January 27, 2021 6:03 PM
To: HDFGroup/hdf5
Cc: Allen Byrne; Review requested
Subject: Re: [HDFGroup/hdf5] Merge PR #274 to 1.12 Branch (#283)
He said it had to be in the PR because the line was new for 1_12 except for the PR.
It provided me an opportunity to try committing from a suggestion in the PR on github, which I’d noticed in the spack repo but hadn’t known how to do. For a minor change (1 missing character in this case) it was much easier than making a change in a clone and pushing it to the fork/branch.
From: Neil Fortner <notifications@github.com<mailto:notifications@github.com>>
Sent: Wednesday, January 27, 2021 5:06 PM
To: HDFGroup/hdf5 <hdf5@noreply.github.com<mailto:hdf5@noreply.github.com>>
Cc: Larry Knox <lrknox@hdfgroup.org<mailto:lrknox@hdfgroup.org>>; Review requested <review_requested@noreply.github.com<mailto:review_requested@noreply.github.com>>
Subject: Re: [HDFGroup/hdf5] Merge PR #274 to 1.12 Branch (#283)
I figured it would save Allen the headache of merge conflicts if I didn't fix it here, but it doesn't matter to me.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCXVUM7WGQL5NYZII6LS4CL5RANCNFSM4WSK22ZQ>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL77KBT7AEOJIFXAKSF4LRDS4CSVBANCNFSM4WSK22ZQ>.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCWUAZSIIHVX53G3BXDS4FMZVANCNFSM4WSK22ZQ>.
|
lrknox
pushed a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problems with vlens and refs inside compound using H5VLget_file_type()