Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Fixes for "something went wrong" #2411

Merged
merged 16 commits into from
Oct 15, 2024
Merged

[Prod] Fixes for "something went wrong" #2411

merged 16 commits into from
Oct 15, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Oct 15, 2024

Description of change

  • Fixes two bugs: Something went wrong page was missing a page title, and using the back button from that page got you mixed results with the side navigation (it would usually stay disappeared)
  • Refactored to abandon the context idea, we now use a more traditional model of error pages, required a few changes to tests

How to test

Confirm that the something went wrong page still functions as it originally did, with the exception of the page now having a meaningful title and the back button bug being resolved

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review October 15, 2024 18:44
@Jones-QuarteyDana Jones-QuarteyDana merged commit 95804ae into production Oct 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants