Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect user on report submission, HSES import fixes, doc updates #382

Merged
merged 20 commits into from
Mar 15, 2021

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Mar 15, 2021

266

Description of change
Whenever a form is submitted/reviewed/accepted, it will redirect the user to the activity reports page with a a banner letting them know the operation was successful.

How to test
Pull down changes.
run server
fill out a form -> get redirected
As manager review a form as Needs Work -> get redirected
As manager review a form as Approved -> get redirected

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

380

Description of change

  • Handle nil grant start and end dates
  • Add ability to kick off an import via CLI

How to test

Production data imports successfully. Ryan tested this on GFE with a production dataset.

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

Documentation

Description of change
Remove references to defaults for maintenance mode scripts

Copy link
Contributor Author

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rahearn rahearn merged commit 28ee247 into HHS:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants