-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect user on report submission, HSES import fixes, doc updates #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove references to defaults for maintenance mode script
Production HSES import fix
Redirect users after submitting a form
Remove references to defaults for maintenance mode script
rahearn
commented
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
PatricePascual-ACF
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
266
Description of change
Whenever a form is submitted/reviewed/accepted, it will redirect the user to the activity reports page with a a banner letting them know the operation was successful.
How to test
Pull down changes.
run server
fill out a form -> get redirected
As manager review a form as Needs Work -> get redirected
As manager review a form as Approved -> get redirected
Issue(s)
Checklist
380
Description of change
nil
grant start and end datesHow to test
Production data imports successfully. Ryan tested this on GFE with a production dataset.
Issue(s)
Checklist
Documentation
Description of change
Remove references to defaults for maintenance mode scripts