Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE 246] Integrate back-end production server + other Flask API updates #374

Merged
merged 9 commits into from
Aug 18, 2023
Merged

[ISSUE 246] Integrate back-end production server + other Flask API updates #374

merged 9 commits into from
Aug 18, 2023

Conversation

daphnegold
Copy link
Contributor

Summary

Fixes #246

Time to review: 15 mins

Changes proposed

The following list of PRs to the template repository have been integrated into this PR.

Context for reviewers

  • Make sure you can still run docker-compose up and successfully start the local server
  • Try out replacing the run command in docker-compose.yml with the Gunicorn command in the Dockerfile to see the prod server start (if you want)
  • Try out make help, it's pretty slick

@daphnegold daphnegold added the topic: backend Backend development tickets label Aug 15, 2023
SammySteiner
SammySteiner approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@SammySteiner SammySteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

documentation/api/database/database-access-management.md Outdated Show resolved Hide resolved
@daphnegold @SammySteiner
Update database-access-management.md
91c3f2c 
Co-authored-by: Sammy <sammysteiner@navapbc.com>
@daphnegold daphnegold merged commit 24b85e2 into main Aug 18, 2023
2 checks passed
@daphnegold daphnegold deleted the daphnegold/issue-246-prod-server branch August 18, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammySteiner SammySteiner SammySteiner approved these changes

@andycochran andycochran Awaiting requested review from andycochran andycochran is a code owner

@acouch acouch Awaiting requested review from acouch acouch is a code owner

Assignees
No one assigned
Labels
topic: backend Backend development tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Integrate back-end production server
2 participants
@daphnegold @SammySteiner