Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Postgres connection timeout to 10 seconds #182

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

lorenyu
Copy link
Contributor

@lorenyu lorenyu commented Aug 8, 2023

Ticket

Changes

  • Increase Postgres connection timeout to 10 seconds
  • Remove QueuePool timeout

Context

Database migrations are occasionally timing out in the platform-test-flask repo.
Tuning this up to 10 seconds to see if that helps.
Also removing the QueuePool timeout which doesn't seem needed.

Example failing migration run:
https://github.com/navapbc/platform-test-flask/actions/runs/5798505305

database migration logs that show timeout expired
image

See 🔒 slack thread

Testing

relying on CI since small change

Copy link
Contributor

@Nava-JoshLong Nava-JoshLong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lorenyu lorenyu merged commit 40ff875 into main Aug 8, 2023
2 checks passed
@lorenyu lorenyu deleted the lorenyu/removepooltimeout branch August 8, 2023 15:33
daphnegold added a commit to HHS/simpler-grants-gov that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants