-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GHA pipeline, install scipy using conda #604
Conversation
Tests generally run fine against PyPy. Looks like we can keep PyPy in the test matrix, what do you think? Tests that install Any suggestion on how to proceed? |
@j-towns The CI/CD setup looks complete now. The Python versions supported by GitHub hosted runners are covered. Known shortcomings:
Other than that this PR is ready to be merged, IMHO. |
Looks great, thanks! |
Hmm actually I think there is still an issue with SciPy. It looks as though it is being installed globally when it should be, but then this warning indicates it is not being found by |
True. This is most certainly because we're mixing Conda and Pip + virtualenv. We might try to install Trying Conda for everything failed when I tried it during this PR. We might try that again, though, and figure out why Tox didn't like it. |
Installing scipy with Pip requires a few prerequisites on the various target platforms. Alternatively, using Conda makes things easier. See StackOverflow for a related discussion.
This is a follow-up on #602.