-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install extras for testing via Tox, test with SciPy+PyPy only on Ubuntu #605
Conversation
Exclude running tests for PyPy 3.7 on Windows entirely Prerequisites for building SciPy and NumPy are easy to obtain for (Ubuntu) Linux, but not so much for macOS and Windows.
@j-towns Test jobs in the GHA setup now run the tests twice, first without scipy, then with scipy installed. This PR is ready for merging. |
Looks great, thanks again @bittner! |
Do you plan to release a version 1.6.3 to PyPI now? It might even be wise to bump the version to 1.7.0 since making It should be sufficient to push a Git tag, the rest is done by the release pipeline, e.g. git tag 1.6.3
git push --tags |
Any news on a release? |
I'll try to get around to this early next week. |
Any news? -- Note that you only need to push a version tag with Git to trigger a release, now. git checkout master && git pull
git tag 1.6.3
git push --tags The publish Action will run, build the package cleanly and push it to PyPI (provided you've added |
@j-towns Any chance you'll get around triggering a release? |
Hey @bittner, I've had an exceptionally busy month - my twin sons were born on the 18th of August. I will get round to this when I can. |
Congratulations! 👶 🍼 👶 🍼 Note (again) that issuing the release should be a matter of:
All the rest is done automatically by the pipeline. See above for explanations, doable in really just a few minutes. |
Looks like I don't have access to Autograd's settings. @duvenaud could you change my role to admin? |
Done. |
@bittner I have no knowledge of how github actions works, and I'm afraid I need clearer instructions on how to setup the publishing to PyPI. You say I need to add PYPI_USERNAME and PYPI_PASSWORD to the project settings (Settings > Secrets and variables). What values should those variables have (and should they be 'variables' as opposed to 'secrets'?)? |
@j-towns A question aside: How do you publish the
They should be secrets and you need to generate them on PyPI.org, like this: 1. Log in on PyPI2. In the user menu on the top right click on "Account settings"3. Scroll down until you read the "API tokens" section4. Click on the Add API token button and fill in the form that opens up5. Use the "Password" value from this token for
|
@j-towns Have you given configuring the two values a try? Note that all this is only to make your life easier. You do it once, and everything is automatic after that. Instead of manual releases from your local computer you simply push a Git tag (e.g. Less time wasted for maintaining your open source project, more time for your family and friends! |
Installing extras via Conda while Tox would use Pip + virtualenv proves to be brittle. We'll factor
scipy
into the list of Tox environments instead, which will also make the test setup more straight-forward, less complex to understand and able to entirely run locally.Tox environments available now (click to expand)
Note that older Python versions (2.7, 3.5, 3.6) will still be able to test with Tox, locally. Since GHA stopped supporting them in their hosted runners the burden is now on the developers, though.
SciPy requires some build prerequisites for PyPy. This is easy to fulfill on (Ubuntu) Linux, not so on the other platforms. We'll skip macOS and Windows for now.
This is a follow-up on #604.