Loading from state is not working correctly

[EdwardMoyse]

I tried to add a default configuration for ATLAS, but it isn't working correctly:
https://github.com/EdwardMoyse/phoenix/blob/add-atlas-default-config/packages/phoenix-ng/projects/phoenix-app/src/app/sections/atlas/atlas.component.ts#L74

specifically, some jet collections should be disabled, and the pixel and SCT hits should be different colours to red.

When you choose 'Load State' from the menu, then it works as expected.

[9inpachi]

Yup, expected.

You have to make ngOnInit async and await for the geometry loading functions. See FASER code.

[EdwardMoyse]

Ah ha! Thanks! However there is still a problem - the menu items state are not updated - for example, two Jet collections should be disabled here:

[9inpachi]

Does this new bug work fine with loading state from the menu?

[9inpachi]

I forgot to put it earlier, but we could also load state from code after all the loading is done (see here).

[EdwardMoyse]

Does this new bug work fine with loading state from the menu?

No. Same issue when loading state from the menu. I like the idea of doing it once loading is done though!

[9inpachi]

No. Same issue when loading state from the menu

Ok, then I will have to look into the export and import state functions. I will give news tonight maybe.

[9inpachi]

No. Same issue when loading state from the menu. I like the idea of doing it once loading is done though!

Indeed. The loading manager is pretty cool I think.

[9inpachi]

So @EdwardMoyse,

The file you exported is wrong / you missed something.

For the file https://github.com/EdwardMoyse/phoenix/blob/add-atlas-default-config/packages/phoenix-ng/projects/phoenix-app/src/assets/files/config/atlas-config.json
If you search for Anti to see the configuration for the Jet collections, you will see that the toggleState is true for all so it's expected that they will show.

I tried exporting to see if it's a problem with export but my export works fine and I can also import the same exported file with disabled / hidden Jets collections without a problem.

So just disable the collections, export again and replace the file in assets.

[9inpachi]

From #188

[EdwardMoyse]

Whoops - you were right ... however in my local tests I was using a file with the correct configuration (not for the final check of loading from the menu, obviously!).

For reasons I don't quite understand, using the loading Manager fixes it! So I think this can be closed now.