Add atlas default config #188
Conversation
| @@ -13,7 +13,8 @@ | |||
| "dist" | |||
| ], | |||
| "scripts": { | |||
| "prepublishOnly": "ng build phoenix-ui-components --prod" | |||
| "prepublishOnly": "node --eval \"console.error('ERROR: Trying to publish a package that has been compiled by NGCC. This is not allowed.\\nPlease delete and rebuild the package, without compiling with NGCC, before attempting to publish.\\nNote that NGCC may have been run by importing this package into another project that is being built with Ivy enabled.\\n')\" && exit 1", | |||
There was a problem hiding this comment.
All cool apart from this. :)
There was a problem hiding this comment.
I meant that you need to discard this file completely (like in the previous PR #186) and not have these changes. For making use of lerna, we have to use this package.json for publishing but NGCC blocks that so this file should not be changed at all.
EdwardMoyse
force-pushed
the
add-atlas-default-config
branch
from
673be12 to
298c075
Compare
Fixes HSF#187 - not quite sure why!
|
I think this works now. |
| @@ -13,7 +13,8 @@ | |||
| "dist" | |||
| ], | |||
| "scripts": { | |||
| "prepublishOnly": "ng build phoenix-ui-components --prod" | |||
| "prepublishOnly": "node --eval \"console.error('ERROR: Trying to publish a package that has been compiled by NGCC. This is not allowed.\\nPlease delete and rebuild the package, without compiling with NGCC, before attempting to publish.\\nNote that NGCC may have been run by importing this package into another project that is being built with Ivy enabled.\\n')\" && exit 1", | |||
There was a problem hiding this comment.
I meant that you need to discard this file completely (like in the previous PR #186) and not have these changes. For making use of lerna, we have to use this package.json for publishing but NGCC blocks that so this file should not be changed at all.
|
Merging this now and will push with the changes because I have to fix the broken CI as well. |
This tries to make the default for ATLAS a bit more useful.
I disabled some jet collections (to stop them overlapping and looking weird) and also some duplicate track collections. I recoloured the Pixel and SCT hits to make them standout a bit more.
As discussed in bug#187 (thanks @9inpachi!) I had to make ngOnInit async and await geometry loading.