Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate website status tests #1124

Merged
merged 5 commits into from
Jul 30, 2020
Merged

Automate website status tests #1124

merged 5 commits into from
Jul 30, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Jul 30, 2020

Makes progress on #933

This adds a script npm run test to test the local website with every URL in the sitemap, and a few others (the sitemap itself, some URLs that should redirect, and a 404 page).

It also make this script run with the Generate GitHub Action so the tests are run on every merge to main.

It also allows the Generate action to be run manually incase you want to test the site. I'm leaving the name the same until GitHub allow you to delete old ones!

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Jul 30, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Jul 30, 2020
@tunetheweb tunetheweb mentioned this pull request Jul 30, 2020
8 tasks
Copy link
Contributor

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The workflow file has unfortunate duplicate, but I don't how how can we DRY it
  • JavaScript function parameters are not separated by spaces (after each comma)

src/tools/test/test_status_codes.js Outdated Show resolved Hide resolved
src/tools/test/test_status_codes.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit b696b55 into main Jul 30, 2020
@tunetheweb tunetheweb deleted the website_tests branch July 30, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants