Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test cases #1167

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Add more test cases #1167

merged 2 commits into from
Aug 5, 2020

Conversation

tunetheweb
Copy link
Member

Add more test cases to test script added in #1124 for fuller coverage.

Goes from 92 test cases to 116 test cases by adding the following:

  • ebook pages
  • robots.txt
  • favicon.ico
  • no year redirects (e.g. /en/ -> /en/2019/) for each supported language
  • unsupported language (zz) redirect
  • 404s for each supported language and year

Also moves the reading of config files to shared.js as now used in two places.

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Aug 5, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Aug 5, 2020
ibnesayeed
ibnesayeed approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added an inline comment, other than that it LGTM!

src/tools/generate/shared.js Outdated Show resolved Hide resolved
@tunetheweb tunetheweb merged commit 1a07f48 into main Aug 5, 2020
@tunetheweb tunetheweb deleted the more-tests branch August 5, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibnesayeed ibnesayeed ibnesayeed approved these changes

Assignees
No one assigned
Labels
development Building the Almanac tech stack
Projects
None yet
Milestone
2020 Platform Development
Development

Successfully merging this pull request may close these issues.
2 participants
@tunetheweb @ibnesayeed