Use binary subscriptions for image #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidma
approved these changes
Jun 18, 2024
oleflb
pushed a commit
to oleflb/hulk
that referenced
this pull request
Jul 15, 2024
oleflb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
What it says. When using text subscriptions for the image, the nao has one core bound up doing nothing but encoding json and you get very low frame rates.
Using binary lessens the load on both CPU and network.
We previously didn't do this because there was no way to subscribe uncompressed images in binary mode because the two were coupled until #987
Fixes #
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
Use color select panel, enjoy massively increased framerate.