-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade syn
, Migrate SerializeHierarchy
to PathSerialize
, PathDeserialize
, PathIntrospect
#987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoellle
requested changes
May 4, 2024
knoellle
reviewed
May 4, 2024
knoellle
reviewed
May 4, 2024
knoellle
requested changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
knoellle
approved these changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
This PR upgrades the
syn
crate to the newest release, which included several breaking changes.While porting our derive macros (
approx_derive
andserialize_hierarchy_derive
), which heavily depend onsyn
, I came up with a newer, cleaner way to express the functionality of our path serialization -> Now calledpath_serde
.Instead of a single trait for all the necessary functionality, I define 3 new traits.
All usages are subsequently adjusted to fit the new separation. Trait bounds can be more specific, and the
exists(path: String)
function was removed as it is duplication of aget_fields().contains(path)
call.ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
path_serde
traitsVisionTop.main.image.rbg.jpeg
. Currently the conversion to rgb is implicitly done when converting to jpegHow to Test
hopefully only compilation...
But better test the communication server with twix or fanta etc...