Enable serializeHierarchy for tuple structs #797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxbotix
changed the title
tuxbotix
changed the title
tuxbotix
force-pushed
the
serialize_hierarchy_for_tuple_structs
branch
from
dd10343 to
1d2e711
Compare
tuxbotix
changed the title
tuxbotix
force-pushed
the
serialize_hierarchy_for_tuple_structs
branch
from
921838a to
a75a08c
Compare
|
superseded by #987 |
auto-merge was automatically disabled
May 5, 2024 18:37
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
Give the ability to handle Tuple Structs.
a.b.c.0will address the first value of a tuple struct under namec.This is the simplest implementation without changing many other functions that handle the identifier names, etc in the derive.Related:
quote!- Tracking issue for future-incompatbility warning 'invalid literal suffix on tuple index' (not a lint) rust-lang/rust#60210Fixes #147
ToDo / Known Issues
matchexpression handlingNamedFieldsandUnNamedFieldsseparately to avoid theenumerate()for all cases.quoteusage. Would be nice to clear them out!Ideas for Next Iterations (Not This PR)
How to Test
SerializeHierarchy