Fix PostgreSQL failure #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the PR there are two exceptions if as database is PostgreSQL is used. `ERROR: column "m.language" must appear in the GROUP BY clause or be used in an aggregate function` If the columns in GROUP BY are simple added again, there are multiple menu entries if multiple home set in one menu. Solution is to use the aggregat function MAX. Tested with * PostgreSQL PDO * MySQL with MySQLi * MySQL with MySQL PDO * MariaDB with MySQL PDO * MariaDB with MySQLi On base of * PR 43862 with Patch Tester * npm update joomla-cypress 1.1.1 * this PR fix-postgres * npx cypress run --spec tests/System/integration/install/multi-lang-menu.cy.js Test Support PR 43862 with ✓ install Japanese language pack (9784ms) ✓ install Ukrainian language pack (8487ms) ✓ install German language pack (8309ms) ✓ enable plugin 'System - Language filter' (1903ms) ✓ create '2nd menu' (1484ms) ✓ create 1st menu entry de as HOME in '2nd menu' (5601ms) ✓ create 2nd menu entry ja as HOME in '2nd menu' (4936ms) ✓ create 3rd menu entry uk as HOME in '2nd menu' (5392ms) ✓ create '3rd menu' (1434ms) * checked five times that the HOME symbol is displayed if more than one Home menu entry is set, otherwise the correct language (uk-UA, ja-JP or de-DE) is displayed for each of the three entries if there is only one menu entry with Home
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the PR joomla#43862 there are two exceptions if as database PostgreSQL is used.
If the columns in GROUP BY are simple added again, there are multiple menu entries shown if multiple home set in one menu.
Solution is to use the aggregate function MAX.
Tested with
On base of:
see multi-lang-menu.cy.js.txt and
