[5.2] Multilang: Remove restrictions for home language menu items #43862

Hackwar · 2024-07-29T14:11:23Z

Summary of Changes

The multilanguage system currently requires each home menu item to be in a separate menu, making the setup unnecessarily complex. There is no reason for forcing this behavior and this PR removes that. With this PR, the restriction is removed and you can put all home menu items into one menu. In the backend menu, the menu listing is changed to display the home icon for menus with more than one home menu item.

Testing Instructions

Setup a multi language website and try to save all home language menu items in one menu.

Actual result BEFORE applying this Pull Request

Error when saving.

Expected result AFTER applying this Pull Request

No errors.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

brianteeman · 2024-07-29T14:57:07Z

I created a multilingual site with 4 languages and the multilingual sample data.
I moved all the menu items to one menu and deleted the other menus

That all worked as expected.

It just left the check in the status module to be updated as the information is no longer correct

coolcat-creations · 2024-07-29T15:55:37Z

Tested Successfully but 2 things to consider:

Should there be another Sample Data Mode for the menus?
When I filter the menu items by language the nesting is not displayed correctly, should there be another filter ?

brianteeman · 2024-07-29T16:47:12Z

When I filter the menu items by language the nesting is not displayed correctly, should there be another filter ?

Can you post a screenshot as it looks ok to me

coolcat-creations · 2024-07-29T16:51:53Z

It looks like this after filtering altough its nested:

brianteeman · 2024-07-29T17:03:41Z

Unable to replicate (or i dont understand)

coolcat-creations · 2024-07-29T17:05:21Z

indeed - yours is still nested -mine not

brianteeman · 2024-07-29T17:06:50Z

indeed - yours is still nested -mine not

please post the full screenshot

coolcat-creations · 2024-07-30T08:40:30Z

Sorry was my mistake, the nested Item was set to "all"
I am still confused that all is not really "All" but just "All" - I mean if something is set to all it should apply for every other language too.

coolcat-creations · 2024-07-30T08:42:24Z

I have tested this item ✅ successfully on bc7029b

Works as expected.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.}

brianteeman · 2024-07-30T08:45:51Z

I have made a pr to your branch for the multilangstatus issue mentioned above

Remove test for home

brianteeman · 2024-07-30T09:57:05Z

I have tested this item ✅ successfully on 1fd1d4e

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.}

Quy · 2024-07-30T14:41:07Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.}

With the PR there are two exceptions if as database is PostgreSQL is used. `ERROR: column "m.language" must appear in the GROUP BY clause or be used in an aggregate function` If the columns in GROUP BY are simple added again, there are multiple menu entries if multiple home set in one menu. Solution is to use the aggregat function MAX. Tested with * PostgreSQL PDO * MySQL with MySQLi * MySQL with MySQL PDO * MariaDB with MySQL PDO * MariaDB with MySQLi On base of * PR 43862 with Patch Tester * npm update joomla-cypress 1.1.1 * this PR fix-postgres * npx cypress run --spec tests/System/integration/install/multi-lang-menu.cy.js Test Support PR 43862 with ✓ install Japanese language pack (9784ms) ✓ install Ukrainian language pack (8487ms) ✓ install German language pack (8309ms) ✓ enable plugin 'System - Language filter' (1903ms) ✓ create '2nd menu' (1484ms) ✓ create 1st menu entry de as HOME in '2nd menu' (5601ms) ✓ create 2nd menu entry ja as HOME in '2nd menu' (4936ms) ✓ create 3rd menu entry uk as HOME in '2nd menu' (5392ms) ✓ create '3rd menu' (1434ms) * checked five times that the HOME symbol is displayed if more than one Home menu entry is set, otherwise the correct language (uk-UA, ja-JP or de-DE) is displayed for each of the three entries if there is only one menu entry with Home

Fix PostgreSQL failure

Hackwar · 2024-08-13T06:08:45Z

We had an issue with PostgreSQL in the admin menu, but thanks to @muhme this is now fixed. @brianteeman @coolcat-creations would you be able to test this again? Basically it would be enough to make sure that the backend menu still functions as expected.

Hackwar · 2024-08-16T13:32:49Z

Back to pending.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.}

brianteeman · 2024-08-17T15:50:10Z

I have tested this item ✅ successfully on 7d82dcd

still ok

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.}

fgsw · 2024-08-18T04:58:58Z

On a nightly build:

Installation Multilingual Sample Data (en-GB, de-DE)
Installation Testing Sample Data
Move all Menu items of both languages to "Main Menu"

See Icon "Home Default" (white House) in "Main Menu Testing" and "Main Menu":

Test System Information:
PHP Built On Darwin Air.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64 x86_64
Database Type mysql
Database Version 8.0.35
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_0900_ai_ci
Database Connection Encryption None
Database Server Supports Connection Encryption Yes
PHP Version 8.3.8
Web Server Apache/2.4.58 (Unix) OpenSSL/1.1.1u mod_fastcgi/mod_fastcgi-SNAP-0910052141
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 5.2.0-alpha4-dev Development [ Uthabiti ] 23-July-2024 16:01 GMT
Joomla Backward Compatibility Plugin Disabled
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0

Hackwar · 2024-08-18T07:20:39Z

@fgsw That is the expected behavior. If a menu contains more than one home menu item, it should show the house icon next to it. We can't really display the different flags, since that would already get ugly with 2 flags.

If you could mark this as tested successfully, then I would try to still get this into beta 1.

fgsw · 2024-08-18T08:08:19Z

I have tested this item ✅ successfully on ea5b52c

@Hackwar Thanks for comment. I thought the icon is only for home-menu-item-all languages.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.}

Hackwar · 2024-08-18T08:09:18Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.}

bembelimen · 2024-08-18T09:15:20Z

Thx

alexandreelise · 2024-09-03T23:40:34Z

Awesome work Super Joomlers! Thanks for this feature

Multilang: Remove restrictions for home language menu items

bc7029b

joomla-cms-bot added the PR-5.2-dev label Jul 29, 2024

Update default.php

657066a

Update com_languages.ini

55ddb31

Merge pull request #64 from brianteeman/patch-5

1fd1d4e

Remove test for home

joomla-cms-bot added the Language Change This is for Translators label Jul 30, 2024

Quy removed the Language Change This is for Translators label Jul 30, 2024

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 30, 2024

Quy added Language Change This is for Translators RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Jul 30, 2024

Merge branch '5.2-dev' into 5.2-langhomemenuitem

525b1a0

pe7er enabled auto-merge (squash) August 10, 2024 12:34

Merge branch '5.2-dev' into 5.2-langhomemenuitem

8e50601

pe7er self-assigned this Aug 10, 2024

pe7er disabled auto-merge August 10, 2024 15:20

muhme mentioned this pull request Aug 12, 2024

Fix PostgreSQL failure Hackwar/joomla-cms#65

Merged

Merge pull request #65 from muhme/fix-postgres

7d82dcd

Fix PostgreSQL failure

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2024

Merge branch '5.2-dev' into 5.2-langhomemenuitem

ea5b52c

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2024

Merge branch '5.2-dev' into 5.2-langhomemenuitem

7cabc67

bembelimen merged commit 638d7b0 into joomla:5.2-dev Aug 18, 2024
2 of 3 checks passed

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 18, 2024

bembelimen added this to the Joomla! 5.2.0 milestone Aug 18, 2024

Hackwar deleted the 5.2-langhomemenuitem branch August 18, 2024 09:15

jgerman-bot mentioned this pull request Aug 19, 2024

[5.2] Multilang: Remove restrictions for home language menu items joomlagerman/joomla#3248

Closed

joomlapl-bot mentioned this pull request Aug 19, 2024

[5.2] Multilang: Remove restrictions for home language menu items JoomlaPolska/jezyk-J4#569

Open

fgsw mentioned this pull request Aug 27, 2024

[5.2] Adapt Multilingual Sample Data as #43862 is merged #43989

Closed

Quy mentioned this pull request Sep 12, 2024

[5.2] Deprecate string #44065

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.2] Multilang: Remove restrictions for home language menu items #43862

[5.2] Multilang: Remove restrictions for home language menu items #43862

Hackwar commented Jul 29, 2024

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 29, 2024

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 29, 2024

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 29, 2024

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 30, 2024

coolcat-creations commented Jul 30, 2024

brianteeman commented Jul 30, 2024

brianteeman commented Jul 30, 2024

Quy commented Jul 30, 2024

Hackwar commented Aug 13, 2024

Hackwar commented Aug 16, 2024

brianteeman commented Aug 17, 2024

fgsw commented Aug 18, 2024

Hackwar commented Aug 18, 2024

fgsw commented Aug 18, 2024

Hackwar commented Aug 18, 2024

bembelimen commented Aug 18, 2024

alexandreelise commented Sep 3, 2024

[5.2] Multilang: Remove restrictions for home language menu items #43862

[5.2] Multilang: Remove restrictions for home language menu items #43862

Conversation

Hackwar commented Jul 29, 2024

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 29, 2024

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 29, 2024

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 29, 2024

brianteeman commented Jul 29, 2024

coolcat-creations commented Jul 30, 2024

coolcat-creations commented Jul 30, 2024

brianteeman commented Jul 30, 2024

brianteeman commented Jul 30, 2024

Quy commented Jul 30, 2024

Hackwar commented Aug 13, 2024

Hackwar commented Aug 16, 2024

brianteeman commented Aug 17, 2024

fgsw commented Aug 18, 2024

Hackwar commented Aug 18, 2024

fgsw commented Aug 18, 2024

Hackwar commented Aug 18, 2024

bembelimen commented Aug 18, 2024

alexandreelise commented Sep 3, 2024