-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [Guided tours] Add a What's New tour when updating to Joomla 5.2 #43966
Conversation
administrator/components/com_admin/sql/updates/mysql/5.2.0-2024-08-22.sql
Outdated
Show resolved
Hide resolved
administrator/components/com_admin/sql/updates/postgresql/5.2.0-2024-08-22.sql
Outdated
Show resolved
Hide resolved
Using images in this way means that they are not translatable. Is that a good idea? |
Is the intention for this to replace Post-Installation messages? |
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2_steps.ini
Outdated
Show resolved
Hide resolved
Regarding "untranslatable" pictures - good point. I would prefer that all possible pictures for translation were like that. Something like the title |
Neither the sql for tours or steps adds a value for ordering. Why does this matter? The module displays tours ordered by ordering. So the whats new is always at the top of the list where it probably should be at the bottom next to the welcome to joomla tour so that it doesnt always display in the dropdown |
not that simple as we dont have a method for you to add an image file into the language pack |
…0-2024-08-22.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…4-08-22.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
The idea is for the What's new tours to highlight new features of a release (major or minor) on an update, of interest to the user, which is not quite the same as the post-installation messages, which targets admin, pointing that there are changes in htaccess... At least, that is how I see it. |
Co-authored-by: Quy <quy@nomonkeybiz.com>
I have tested this item ✅ successfully on 97b4ef3 NOTE: on the 2nd image, the envelope icon is hard to see for someone that sees perfectly well so definitely not good enough for those with visual impairments. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966. |
Thank you for testing Emmanuel @exlemor! I have updated the image in question. |
Hello @fgsw, you have to install the update package, you cannot use the full install package. I have updated the test section to add that information (sorry, it was missing). Thanks for trying the PR out! |
I have tested this item ✅ successfully on 97b4ef3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966. |
I have tested this item ✅ successfully on 97b4ef3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966. |
Thanks @obuisard ! |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Summary of Changes
This PR adds a tour that highlights new features introduced in Joomla 5.2.
Testing Instructions
Download the update package, not the full install as the tour is only available on updates!
It is possible to find the tour in the list of tours at the top of the Joomla dashboard and run it manually.
Make sure you see images when running the tour (on the first step only) and when editing the tour (System -> Manage -> Guided tours).
Actual result BEFORE applying this Pull Request
No tour highlighting new features for Joomla 5.2.
Expected result AFTER applying this Pull Request
What’s New in Joomla 5.2! tour is available.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed