Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided tours] Add a What's New tour when updating to Joomla 5.2 #43966

Merged
merged 39 commits into from
Sep 12, 2024

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Aug 23, 2024

Summary of Changes

This PR adds a tour that highlights new features introduced in Joomla 5.2.

Testing Instructions

Download the update package, not the full install as the tour is only available on updates!

It is possible to find the tour in the list of tours at the top of the Joomla dashboard and run it manually.
Make sure you see images when running the tour (on the first step only) and when editing the tour (System -> Manage -> Guided tours).

Actual result BEFORE applying this Pull Request

No tour highlighting new features for Joomla 5.2.

Expected result AFTER applying this Pull Request

What’s New in Joomla 5.2! tour is available.

image

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Aug 23, 2024
@obuisard obuisard changed the title [5.2] [Guided tours] Add a What's New tour when updating Joomla [5.2] [Guided tours] Add a What's New tour when updating to Joomla 5.2 Aug 23, 2024
@brianteeman
Copy link
Contributor

Using images in this way means that they are not translatable. Is that a good idea?

@brianteeman
Copy link
Contributor

Is the intention for this to replace Post-Installation messages?

@Kostelano
Copy link
Contributor

Kostelano commented Aug 23, 2024

Regarding "untranslatable" pictures - good point. I would prefer that all possible pictures for translation were like that.

Something like the title enhancedtourheader_en-GB.png. If the system does not find a picture with the title enhancedtourheader_YOUR_LANGUAGE_CODE.png, the standard en-GB is loaded.

@brianteeman
Copy link
Contributor

Neither the sql for tours or steps adds a value for ordering.

Why does this matter? The module displays tours ordered by ordering. So the whats new is always at the top of the list where it probably should be at the bottom next to the welcome to joomla tour so that it doesnt always display in the dropdown

image

@brianteeman
Copy link
Contributor

Regarding "untranslatable" pictures - good point. I would prefer that all possible pictures for translation were like that.

Something like the title enhancedtourheader_en-GB.png. If the system does not find a picture with the title enhancedtourheader_YOUR_LANGUAGE_CODE.png, the standard en-GB is loaded.

not that simple as we dont have a method for you to add an image file into the language pack

obuisard and others added 2 commits August 24, 2024 09:50
…0-2024-08-22.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…4-08-22.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@obuisard
Copy link
Contributor Author

Is the intention for this to replace Post-Installation messages?

The idea is for the What's new tours to highlight new features of a release (major or minor) on an update, of interest to the user, which is not quite the same as the post-installation messages, which targets admin, pointing that there are changes in htaccess... At least, that is how I see it.

@exlemor
Copy link

exlemor commented Sep 3, 2024

I have tested this item ✅ successfully on 97b4ef3

I have tested this successfully.. everything worked great.

NOTE: on the 2nd image, the envelope icon is hard to see for someone that sees perfectly well so definitely not good enough for those with visual impairments.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966.

@obuisard
Copy link
Contributor Author

obuisard commented Sep 4, 2024

NOTE: on the 2nd image, the envelope icon is hard to see for someone that sees perfectly well so definitely not good enough for those with visual impairments.

Thank you for testing Emmanuel @exlemor! I have updated the image in question.

@fgsw
Copy link

fgsw commented Sep 4, 2024

Using prebuilt package no "Whats new in Joomla 5.2" available:

Untitled1

"Show all tours":

Untitled2
index.php?option=com_guidedtours&view=tours shows 12 published and no unpublished tours.

@obuisard
Copy link
Contributor Author

obuisard commented Sep 4, 2024

Using prebuilt package no "Whats new in Joomla 5.2" available:

Hello @fgsw, you have to install the update package, you cannot use the full install package.
When on new installs, you get the Welcome tour.
On updated site, you get the What's new tour.

I have updated the test section to add that information (sorry, it was missing).

Thanks for trying the PR out!

@fgsw
Copy link

fgsw commented Sep 6, 2024

I have tested this item ✅ successfully on 97b4ef3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966.

@exlemor
Copy link

exlemor commented Sep 6, 2024

I have tested this item ✅ successfully on 97b4ef3

I have re-tested this successfully with the latest PR Update.zip from ~17:26 UTC of today.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966.

@Hackwar
Copy link
Member

Hackwar commented Sep 11, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43966.

@pe7er pe7er self-assigned this Sep 11, 2024
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 11, 2024
@pe7er pe7er merged commit aa7197e into joomla:5.2-dev Sep 12, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 12, 2024
@pe7er
Copy link
Contributor

pe7er commented Sep 12, 2024

Thanks @obuisard !

@Quy Quy added this to the Joomla! 5.2.0 milestone Sep 12, 2024
tecpromotion added a commit to tecpromotion/joomla-cms that referenced this pull request Sep 13, 2024
Hackwar pushed a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.