Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Deprecate string #44065

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[5.2] Deprecate string #44065

merged 1 commit into from
Sep 13, 2024

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Sep 12, 2024

Pull Request for Issue #43862 .

Summary of Changes

Deprecate a string that was removed in #43862.

https://github.com/joomla/joomla-cms/pull/43862/files#diff-35ab68a775380c625262f0f2085bbd5d417fe67810f4a89c5b9af251670d6dc9L272

Testing Instructions

Code review.

@Quy Quy added the bug label Sep 12, 2024
@Quy Quy added this to the Joomla! 5.2.0 milestone Sep 12, 2024
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Sep 12, 2024
Copy link
Contributor

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Quy

@tecpromotion
Copy link
Contributor

RTC

@Hackwar Hackwar merged commit 9b7d170 into joomla:5.2-dev Sep 13, 2024
3 checks passed
@brianteeman
Copy link
Contributor

This should not have been merged. Strings in this file are also used by extensions and we don't have a way of notifying 3pd that strings will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants