Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Usability: Back-end - Add item position and total count to Page Navigation #43575

Merged

Conversation

HLeithner
Copy link
Member

Pull Request for Issue #43548 alternative to #43570 .

This pr is an alternative to #43570 and used as inspiration.

Summary of Changes

Add item position and total count to Page Navigation

image

The total and the current item position will be present on any list view that uses pagination->getListFooter(); ?>

Testing Instructions

Go to the backend and check list views.

Actual result BEFORE applying this Pull Request

No Line like shown in the image

Expected result AFTER applying this Pull Request

An additional line with some basic information of the position and total amount of the list view.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: Screenshots might needs to be updated

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Additonal parameter for the layout

  • No documentation changes for manual.joomla.org needed

HLeithner and others added 3 commits May 30, 2024 14:37
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
@brianteeman
Copy link
Contributor

I closed my PR in favour of this one. It does more than was requested but that's a good thing.

NOTE:
Note that both this implementation and the alternative are not completely correct when it comes to accessibility. The information should really be in the caption element

@chmst
Copy link
Contributor

chmst commented May 30, 2024

I like this feature, tested and it works perfectly.

What do you think about using a badge?
grafik

@brianteeman I first had the same thought as you but cannot find a rule which requires presenting the information in the caption. Do you have a link?

@brianteeman
Copy link
Contributor

A table caption is intended to describe a table - if we include how the table is sorted and filtered in that description (we do) then by the same toke we should include how many items are in the table.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on d7794ad

Better to have it and it not be perfect for accessibility than not have it at all.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575.

@alikon
Copy link
Contributor

alikon commented Jun 2, 2024

I have tested this item ✅ successfully on d7794ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575.

@alikon
Copy link
Contributor

alikon commented Jun 2, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 2, 2024
@pe7er pe7er self-assigned this Jun 3, 2024
@pe7er pe7er merged commit aa3ab7c into joomla:5.2-dev Jun 3, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 3, 2024
@pe7er
Copy link
Contributor

pe7er commented Jun 3, 2024

Thank you @brianteeman and @HLeithner for coding this feature!

@Quy Quy added this to the Joomla! 5.2.0 milestone Jun 3, 2024
@HLeithner HLeithner deleted the 5.2/feature/pagination-item-position branch October 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants