-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Usability: Back-end - Add item position and total count to Page Navigation #43575
[5.2] Usability: Back-end - Add item position and total count to Page Navigation #43575
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
I closed my PR in favour of this one. It does more than was requested but that's a good thing. NOTE: |
I like this feature, tested and it works perfectly. What do you think about using a badge? @brianteeman I first had the same thought as you but cannot find a rule which requires presenting the information in the caption. Do you have a link? |
A table caption is intended to describe a table - if we include how the table is sorted and filtered in that description (we do) then by the same toke we should include how many items are in the table. |
I have tested this item ✅ successfully on d7794ad This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575. |
I have tested this item ✅ successfully on d7794ad This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575. |
Thank you @brianteeman and @HLeithner for coding this feature! |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Pull Request for Issue #43548 alternative to #43570 .
This pr is an alternative to #43570 and used as inspiration.
Summary of Changes
Add item position and total count to Page Navigation
The total and the current item position will be present on any list view that uses pagination->getListFooter(); ?>
Testing Instructions
Go to the backend and check list views.
Actual result BEFORE applying this Pull Request
No Line like shown in the image
Expected result AFTER applying this Pull Request
An additional line with some basic information of the position and total amount of the list view.
Link to documentations
Please select:
Documentation link for docs.joomla.org: Screenshots might needs to be updated
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Additonal parameter for the layout
No documentation changes for manual.joomla.org needed