[5.2] [Guided tours] Add missing auto start parameter in the user interface of tours #43690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothing
Added auto start option
Added autostart parameter
Added autostart label translation
Revert test code
brianteeman
reviewed
Jun 21, 2024
Reorganise attributes of the field Co-authored-by: Brian Teeman <brian@teeman.net>
|
I have tested this item ✅ successfully on 535cd9a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43690. |
1 similar comment
|
I have tested this item ✅ successfully on 535cd9a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43690. |
|
@obuisard Change Draft status? |
obuisard
changed the title
4 tasks
Quy
changed the title
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43690. |
|
Thank you for your contribution! 😃 |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 19, 2024
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The autostart parameter has been introduced in Joomla 5.1 to facilitate the autostart feature and mainly the welcome tour.
This PR goes a step further and adds the ability to make a tour auto-start-able in the interface.
The purpose of the PR is to just add the ability to modify the parameter from the edit view.
The functionality for auto-starting tours is presented in a separate PR #43814.
Testing Instructions
Go to System -> Guided Tours.
Pick a tour.
Check that the option is present.
Set it on.
Duplicate the tour.
Make sure the duplicated tour replicates the original tour auto-start value.
Note. The welcome tour, at present (until the addition of the joint PR), if set to auto-start, will run once and be automatically set to auto-start: false after the run.
Tours set to auto start will not start automatically with this PR alone.
Actual result BEFORE applying this Pull Request
No auto start parameter.
Expected result AFTER applying this Pull Request
The auto start parameter can be changed from the tour edit view.
Link to documentations
Please select:
[x ] Documentation link for docs.joomla.org: Edit Tour
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed