-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Search for content checked out by an author #43965
Conversation
Signed-off-by: BrianTeeman <brian@teeman.net>
I have tested this item ✅ successfully on 555b375 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965. |
administrator/components/com_content/src/Model/ArticlesModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@nomonkeybiz.com>
administrator/components/com_content/src/Model/ArticlesModel.php
Outdated
Show resolved
Hide resolved
@brianteeman Now after the last change I think you should change the description of the expected result in the testing instructions. Currently it says:
I think it should be:
|
@richard67 done |
@fgsw Could you test again? Thanks in advance. |
I have tested this item ✅ successfully on 0fc5cf1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965. |
I have tested this item ✅ successfully on 0fc5cf1 Just a comment: Although this is a much-needed feature, having the ability to list checked-out articles by ALL users would also be super useful for sites that have a number of authors. Perhaps something like "checkedout:*" or just "checkedout". This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965. |
@maintainers an alternative to this approach would be to add a filter for checked out and then it could be additionally combined with the existing author filter. |
Thank you for your contribution @brianteeman! |
thanks |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Pull Request for Issue #43957 .
Summary of Changes
Adds the ability to search for all content that is checked out by a user
Testing Instructions
Check out some articles
Actual result BEFORE applying this Pull Request
There is no way to filter or search the list of articles by their checked out status
Expected result AFTER applying this Pull Request
Using the search input you can now search for content checkout out by a specified author (using their username or real name) by entering CHECKEDOUT: author. Obviously replacing author with their real name or username
If accepted documentation will be created
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed