Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Search for content checked out by an author #43965

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Aug 22, 2024

Pull Request for Issue #43957 .

Summary of Changes

Adds the ability to search for all content that is checked out by a user
image

Testing Instructions

Check out some articles

Actual result BEFORE applying this Pull Request

There is no way to filter or search the list of articles by their checked out status

Expected result AFTER applying this Pull Request

Using the search input you can now search for content checkout out by a specified author (using their username or real name) by entering CHECKEDOUT: author. Obviously replacing author with their real name or username

If accepted documentation will be created

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

checkedout

Signed-off-by: BrianTeeman <brian@teeman.net>
@fgsw
Copy link

fgsw commented Aug 23, 2024

I have tested this item ✅ successfully on 555b375


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965.

@richard67
Copy link
Member

@brianteeman Now after the last change I think you should change the description of the expected result in the testing instructions.

Currently it says:

Using the search input you can now search for content created by a specified author

I think it should be:

Using the search input you can now search for content checked out by a specified user

@brianteeman
Copy link
Contributor Author

@richard67 done

@richard67
Copy link
Member

@fgsw Could you test again? Thanks in advance.

@crommie
Copy link

crommie commented Aug 24, 2024

I have tested this item ✅ successfully on 0fc5cf1

Works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965.

@bascherz
Copy link

I have tested this item ✅ successfully on 0fc5cf1

Works as expected on a freshly-created 5.2.0-beta1 site.

Just a comment: Although this is a much-needed feature, having the ability to list checked-out articles by ALL users would also be super useful for sites that have a number of authors. Perhaps something like "checkedout:*" or just "checkedout".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43965.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@brianteeman
Copy link
Contributor Author

@maintainers an alternative to this approach would be to add a filter for checked out and then it could be additionally combined with the existing author filter.

@Hackwar Hackwar enabled auto-merge (squash) August 29, 2024 13:17
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 29, 2024
@Hackwar
Copy link
Member

Hackwar commented Aug 29, 2024

Thank you for your contribution @brianteeman!

@Hackwar Hackwar merged commit 50726be into joomla:5.2-dev Aug 29, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2024
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants