Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Mail Template Attachments description #43898

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

Took me a while to work out why I did not see any field to select a file attachment to go with my mail templates. The problem was that you have to define the folder in the component option first or the field is never displayed.
Check that the mail template options has a blank entry for the attachments folder
Open any mail template and there is nowhere to attach a field
Change the mail template options entry for the attachments folder to any valid folder on the server
Open any mail template and scroll to the bottom and you will see the abilility to attach a field

Testing Instructions

Go to the mail template options and click on the Toggle Inline Help button

Actual result BEFORE applying this Pull Request

"Provide a relative path from the root of your installation to the folder containing files that you want to attach to the mails."

image

Expected result AFTER applying this Pull Request

"Provide a relative path from the root of your installation to the folder containing files that you want to attach to the mails. If left blank then the attachments option will not be available in the mail template."

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Notes

I made this as a PR to 5.2 as its more extensive a language string change than simply grammar or spelling but maybe maintainers want to merge it into an earlier release

Signed-off-by: BrianTeeman <brian@teeman.net>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Aug 9, 2024
@fgsw
Copy link

fgsw commented Aug 9, 2024

I have tested this item ✅ successfully on 110ea3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Aug 9, 2024

I have tested this item ✅ successfully on 110ea3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898.

@Quy
Copy link
Contributor

Quy commented Aug 9, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 9, 2024
@wilsonge wilsonge enabled auto-merge (squash) August 9, 2024 13:45
@wilsonge wilsonge added this to the Joomla! 5.2.0 milestone Aug 9, 2024
@wilsonge wilsonge merged commit 7af40ef into joomla:5.2-dev Aug 9, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 9, 2024
@brianteeman
Copy link
Contributor Author

Thansks @wilsonge

@brianteeman brianteeman deleted the mail_attachments branch August 9, 2024 14:56
@wilsonge
Copy link
Contributor

wilsonge commented Aug 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants