-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Mail Template Attachments description #43898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BrianTeeman <brian@teeman.net>
I have tested this item ✅ successfully on 110ea3c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898. |
1 similar comment
I have tested this item ✅ successfully on 110ea3c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898. |
Thansks @wilsonge |
Thanks! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 19, 2024
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Took me a while to work out why I did not see any field to select a file attachment to go with my mail templates. The problem was that you have to define the folder in the component option first or the field is never displayed.
Check that the mail template options has a blank entry for the attachments folder
Open any mail template and there is nowhere to attach a field
Change the mail template options entry for the attachments folder to any valid folder on the server
Open any mail template and scroll to the bottom and you will see the abilility to attach a field
Testing Instructions
Go to the mail template options and click on the Toggle Inline Help button
Actual result BEFORE applying this Pull Request
"Provide a relative path from the root of your installation to the folder containing files that you want to attach to the mails."
Expected result AFTER applying this Pull Request
"Provide a relative path from the root of your installation to the folder containing files that you want to attach to the mails. If left blank then the attachments option will not be available in the mail template."
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Notes
I made this as a PR to 5.2 as its more extensive a language string change than simply grammar or spelling but maybe maintainers want to merge it into an earlier release