Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] SEF: Add "Strict Routing" option #43432

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented May 6, 2024

Summary of Changes

Joomla has been improving its SEO performance constantly and with hopefully 5.2 we will allow for a stricter routing, which removes a lot of duplicate content. This PR introduces a switch to enable all these new behaviors, but does not implement them itself. It is basically a preparation for #42850, #42854 and #42989.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels May 6, 2024
@Hackwar Hackwar marked this pull request as draft May 6, 2024 18:56
@Hackwar Hackwar marked this pull request as ready for review May 11, 2024 14:16
@robbiejackson
Copy link

I've tested this functionality on my Joomla 5.1 instance and it worked ok.

I checked that the form displayed correctly, showed the correct online help and stored the correct values in the params field in the database.

@Quy
Copy link
Contributor

Quy commented Jul 18, 2024

Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43432 and use the blue "Test this" button at the top left corner, select your test result and submit. Otherwise your test will not be counted. A PR needs 2 successful human tests to get accepted.

@robbiejackson
Copy link

I have tested this item ✅ successfully on aaf1684

I checked that the form displayed correctly, showed the correct online help and stored the correct values in the params field in the database.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43432.

@chmst
Copy link
Contributor

chmst commented Jul 21, 2024

I have tested this item ✅ successfully on cc0c919


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43432.

1 similar comment
@SniperSister
Copy link
Contributor

I have tested this item ✅ successfully on cc0c919


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43432.

@Quy Quy added the RTC This Pull Request is Ready To Commit label Jul 21, 2024
@pe7er pe7er self-assigned this Aug 15, 2024
@pe7er pe7er enabled auto-merge (squash) August 15, 2024 14:29
@pe7er pe7er merged commit 3ba176e into joomla:5.2-dev Aug 15, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2024
@pe7er
Copy link
Contributor

pe7er commented Aug 15, 2024

Thanks @Hackwar !

@Quy Quy added this to the Joomla! 5.2.0 milestone Aug 15, 2024
@Hackwar Hackwar deleted the 5.2-router-strict branch August 15, 2024 15:18
@SemaphoreOxalis
Copy link

Hi,
Before J!5 I red that any new feature could be validated without documentation. So could we have documentation about this one because it seems a nice one but I don't get why, how and what is the impact (good or not) of each option.
Thanks for the work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants