-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Articles Module #43738
Articles Module #43738
Conversation
Layout horizontal only works in some module positions. Is this intentional? Took me a while to work out why i couldnt get the columns to work |
No, no intentional at all... But the number of columns is related to the width of the container (maybe something for the description of the field). For example you can set 3 columns and in main-bottom you will get 2, because the container is smaller than 992px |
The label "card style" confused me - I thought it referred to placing a border around the article. Not that it made the entire article a link, When Card style is enable you should not be able to make the category a link as it will never work. Same is true for the tags |
Articles Info Layout I think it makes more sense to describe this as single line and multiline as opposed to horizontal and vertical |
Good idea! Thank you |
No matter what options you chose it is always output as a list. When you just have the article titles that makes sense but I dont believe it is correct to display articles with content in this way and it should be a div. We dont display a content blog view as a list |
I understand card style as a combination of the two things. I was not sure, if it is good to put so much css on the module itself and better do it in Cassiopeia (as is now in the case of mod_articles_newsflash).
That is true ... Maybe it will be better to remove the possibility to display category and tags if card style is selected ... It is always difficult to get all ideas working well (and I have a lot of other ideas ;-) ) |
I was following a tutorial for accessible cards: https://gehirngerecht.digital/barrierefreie-cards-erstellen-schritt-fuer-schritt-anleitung/ |
That's true but it would also be true for all the blog article views. For me it is an abuse of the list semantics |
Merged the changes done by @bembelimen (thank you for cleaning the code) and corrected an error in the logic of displaying article imagas that was interfering with the truncation of the intro text. |
@drmenzelit Could you fix PHPCS errors reported here https://ci.joomla.org/joomla/joomla-cms/78353/1/7 ? Thanks in advance. |
@richard67 I was on it, done ... I hope ;-) |
Hello, |
I have tested this item ✅ successfully on 56845d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43738. |
@RickR2H I tested this morning and was unable to recreate the introtext issue I raised on August 23. I have no issues. Everything looks fine. |
I'm working with Ordering Options today and may have another issue—order by alias seems to be ordering by title. Here's my setup: Removed configuration.php from the root.
Install the Articles module and configure:
I'm observing that the articles are always ordered by Title, regardless of the Author or Alias value. Question about how Author and AliasIn Display Options we have Author (which will display the Created by Alias if defined in the article, otherwise it displays the Created by user), but in Ordering Options we have Alias, which I'm assuming would function in a similar way...ordering by either Created by or Created by Alias. Should these be labeled the same, either Author or Alias, to be consistent? Finish Publishing DateIn Ordering Options we have the option to order by Finish Publishing Date but there is no display option for the finish publishing date. Should there be? |
@JeffOnWire I think there is a misunderstanding of Alias ... Alias refers to the alias of the article, this one on the right: |
@drmenzelit Ah, thank you. |
Thank you @drmenzelit for this great feature! |
Sorry, so it doesn't get lost, I created #44088. |
@Kostelano thank you for the hint, we removed some parameters on the last version of the module before the merge and it seems we forgot to chech this one. We will correct it. |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Pull Request for Issue #43404 .
Summary of Changes
This PR is a follow-up of #43610 that was closed some days ago.
I did several changes to the code, added some parameters (for layout) and functions (include specific articles by ID) and created a CSS file to control the layout. After this get merged additional changes in the CSS from Cassiopeia can be done.
Testing Instructions
I you don't directly install the PR package, you will need to run npm (npm run build:css) to get the CSS file.
With this module you can replace the existing mod_articles_xx. All you need is to play with the parameters.
Articles - Archived -> Filter Archived Articles only
Articles - Category -> Select category, play with parameter, use filter, group them, etc.
Articles - Latest -> Change ordering to newest first
Articles - Most Read -> Change ordering to hits
Articles - Newsflash -> Select category, play with parameter, use filter, group them, etc.
Toggle the inline help to get more information about some fields.
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed