Ensure stdout silence in console pipe out mode plus a few minor fixups

[rndi]

• Ensure stdout silence in console pipe out mode
• Ignore non-positive number timeouts
• Fix target validation typo
• Adjust help wording

[ethouris]

That's rather a wrong approach - if a user explicitly requested verbose mode and output to stdout, issue an error and exit with failure. The user should be informed that this combination is impossible, not that it "silently doesn't work".

[rndi]

The change will make the application "silently work" when destination is stdout. I think this is way better approach than needlessly barking at the user since user's intention is clear.

[ethouris]

Users will complain "why the -v option doesn't work?". Moreover, as suggested below, you can make an additional option like -v2 that will do verbose logs to stderr.

[ethouris]

This transmit_verbose is now renamed to Verbose::on. And it's easier to simply change cout into Verb() and remove << endl.

[matiaspl]

Shouldn't verbose (or any in that matter) console log output go to stderr instead? Ffmpeg does it this way so that logs don't interfere with input/output pipes. 2018-02-13 9:43 GMT+01:00 Sektor van Skijlen <notifications@github.com>:

…

***@***.**** requested changes on this pull request. ------------------------------ In apps/srt-live-transmit.cpp <#275 (comment)>: > @@ -300,6 +300,13 @@ int main( int argc, char** argv ) return 1; } + if (params[1].rfind("file://con", 0) == 0) + { + // ensure we are quiet That's rather a wrong approach - if a user explicitly requested verbose mode and output to stdout, issue an error and exit with failure. The user should be informed that this combination is impossible, not that it "silently doesn't work". ------------------------------ In apps/transmitmedia.cpp <#275 (comment)>: > @@ -949,10 +949,10 @@ class UdpCommon { int ttl = stoi(attr.at("ttl")); int res = setsockopt(m_sock, IPPROTO_IP, IP_TTL, (const char*)&ttl, sizeof ttl); - if (res == -1) + if (transmit_verbose && res == -1) cout << "WARNING: failed to set 'ttl' (IP_TTL) to " << ttl << endl; This transmit_verbose is now renamed to Verbose::on. And it's easier to simply change cout into Verb() and remove << endl. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#275 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB049mGmQccDx7LfxP9wX95lzGMW7wMCks5tUUsugaJpZM4SDNcK> .

[ethouris]

The trouble is that we do use stderr in this app for some other kind of messages, such that cannot be silenced, which inform about some serious problems. Actually the verbose logging was predicted only for testing purposes, including user testing, as this displays the size of every packet that was passed between two media, so it's usually connected with storing the stream into a file.

I think we might at least use an option to turn on verbose mode, but redirect it to stderr. @rndi I think there could be something like -v2 option, what do you think?