Fixed problem with encryption decision and status report on encryption failure. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 23, 2018 18:20
…load still sent, even tho recv won't decrypt it.
ethouris
changed the title
added 6 commits
March 27, 2018 13:35
ethouris
force-pushed
the
dev-fix-secure-sending
branch
from
4e7499a to
240b458
Compare
added 6 commits
March 28, 2018 10:40
…turn value imposed by initiator.
…e. This should make KMREQ rely on advertised PBKEYLEN. Advertised value overrides SRTO_PBKEYLEN unless SRTO_SENDER is set.
…d advertising PBKEYLEN
…ength. Improved logs
Gummilion
added a commit
to Gummilion/srt
that referenced
this pull request
May 10, 2018
* dev: (21 commits) Fix SRT file transmit app to work in non-blocking mode (Haivision#334) Ensure stdout silence in console pipe out mode plus a few minor fixups (Haivision#275) Replaced hardcoded installdirs with GNUInstallDirs. Fixed some status messages. (Haivision#323) Breaking connection when recv buffer inflation caused sequence discrepancy (Haivision#300) Fixed problems with encryption decision and status report on encryption failure. (Haivision#318) Fixed invalid symbol names in doc (Haivision#311) Dev add version to winpackages (Haivision#328) Android build for dev (Haivision#326) Change License to MPLv2.0 (Haivision#327) Used constants for input rate. Fixed after-start rate sampling period to 1s (Haivision#315) Made SockaddrToString use only numeric string by default (Haivision#312) Ported change in Haivision#307 PR to dev Fixed SockaddrToString to format as 4dotIP if unknown (Haivision#299) Build with debug information for lldb on iOS platform (Haivision#302) Fix for sudden stop sending data on macOS/iOS (Haivision#303) Fix broken build when testing apps enabled (Haivision#296) Removed all code introduced for CBR (Haivision#293) Added API to get instantaneous stats instead of moving averages for a… (Haivision#288) Added toolchain file and build instruction for iOS (Haivision#286) Fix windows build (Haivision#290) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix that enabled connection even if the encryption is not agreed upon has caused that a listener party that set a password could send also unencrypted stream, if the connecting caller party has set no password. This was to make it possible to send a stream by a party that did not set a password, but it has simultaneously allowed the party that set a password send unencrypted stream.
This fix checks if the encryption was requested (by checking sender keylen), but not possible (the encryption context for sending was not created due to failed KMX), if so, the
CUDT::sendmsg2function (the central sending function for all types of buffer sending) returns with error.This error, again, should never fire now because the context for sending is always created, worst case if KMX process fails, the encryption will be done for nothing, but still done, and packets will be sent.
Also fixes problems with correct status reporting on KMX failure.