-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 32-bit Windows and consume Pthreads from NuGet #614
Conversation
* -add x86 compile to appveyor build for win * -tune the way VS SLN gets platform value * -make use of quotes consistent in appveyor * -factor bitness into folder names for libs * -add 64bit hint for pthread_include_dir * -add bitness to artifact name * -add VS_VERSION to artifact name * -gather PDB for debug builds * -set more sensible build number in appveyor
-remove vs2013 hangovers -add .gitingore extras -stop pthreads going into built package zip
Take a look at the failed builds, I did exactly that but it seemed to snarl
up.
I was experimenting on my personal laptop rather than my work PC, so maybe
my laptop was screwed up instead :)
Either way, doing it under two PRs probably makes it clearer for people
looking through what changed, even if it is just my failure to spot
something simple...
L
…On Tue, 26 Mar 2019, 21:28 Roman, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .gitignore
<#614 (comment)>:
> @@ -0,0 +1,23 @@
+/.vs
OK, fair enough. It is strange that you run into anything that would
require CMake changes: I imagined this would be as simple as adding a
couple of lines to .appveyor.yml (mkdir .build && cd .build) and adjusting
some paths in gather-package.bat but maybe I am missing something vital. I
should try to do this on a branch myself and see what issues I run into. I
did not mean to complicate things for you @lewk2
<https://github.com/lewk2> and thank you very much for your efforts!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#614 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABwKsNzPjjDMT5Y9HdEezzimDSXDTOUUks5vapD8gaJpZM4b5zJ5>
.
|
I appreciate these change proposition which removes the PThreadWIN32 external dependency on Win (If I understand correctly). It makes SRT lib more easy to embed in a cross-platform project! |
This really does not remove the dependency from runtime - it just removes the need to repeatedly build and rebuild the lib file for pthreads components, since the lib is just grabbed from NuGet instead. It therefore makes the build both quicker on the CI server, and easier for people to set up local workstation builds. |
Ok I see! thanks for details |
-no win metadata attached to Cygwin
-adjust cmake to ask for var pointing at pthreads if not found by glob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflict in .gitignore
-add new sub-sections for win32 to main MAF -update cmakelist to read win32 subsection from MAF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all done - seems windows git does some magic eating that last line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if you will be flattening history on this PR to some meaningful commits. Otherwise, I can squash all history into a single commit.
This will return, but scripted, with metadata settings
This PR contains two specific enhancements:
It also includes various small cleanups within the build system for consistency and clarity (e.g. consistent use of quotes).
It also drops VS2013 from CI, since with the inclusion of 32-bit configurations caused a doubling of build time.