Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(side-dag): implement missing side-dag related tests #1064

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 12, 2024

Depends on #1069

Motivation

Implement missing tests for side-dag code.

Acceptance Criteria

  • Change PoaBlockProducer so it does not require a HathorManager for initialization, and update builders accordingly. Add manager calculated property.
  • Move PoA tests from test_block.py to test_poa.py.
  • Implement new test_poa_block_producer.py and test_poa_simulation.py.
  • Update test_verification.py.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the tests label Jun 12, 2024
@glevco glevco self-assigned this Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.04%. Comparing base (06a93b8) to head (59295e8).

Files Patch % Lines
hathor/builder/cli_builder.py 22.22% 5 Missing and 2 partials ⚠️
hathor/builder/builder.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   84.60%   85.04%   +0.43%     
==========================================
  Files         309      309              
  Lines       23370    23396      +26     
  Branches     3523     3529       +6     
==========================================
+ Hits        19772    19896     +124     
+ Misses       2889     2799      -90     
+ Partials      709      701       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the tests/side-dag branch 4 times, most recently from 054cb52 to edf4ab4 Compare June 13, 2024 01:48
@glevco glevco marked this pull request as ready for review June 13, 2024 01:55
@glevco glevco requested review from jansegre and msbrogli as code owners June 13, 2024 01:55
msbrogli
msbrogli previously approved these changes Jun 13, 2024
tests/tx/test_verification.py Outdated Show resolved Hide resolved
jansegre
jansegre previously approved these changes Jun 13, 2024
@glevco glevco mentioned this pull request Jun 20, 2024
1 task
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from a750cbd to e543cbb Compare June 20, 2024 13:41
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from e543cbb to 8d39404 Compare July 5, 2024 17:57
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from 8d39404 to b525727 Compare July 8, 2024 21:22
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from b525727 to b85b855 Compare July 12, 2024 23:16
Base automatically changed from feat/side-dag/poa-block-producer to master July 15, 2024 15:40
@glevco glevco dismissed stale reviews from jansegre and msbrogli July 15, 2024 15:40

The base branch was changed.

@glevco glevco force-pushed the tests/side-dag branch 2 times, most recently from 91ac26e to 9274be7 Compare July 15, 2024 16:54
@glevco glevco changed the base branch from master to refactor/misc-improvements July 15, 2024 16:54
@glevco glevco force-pushed the refactor/misc-improvements branch from eead7ac to 6a9693d Compare July 15, 2024 20:20
@glevco glevco force-pushed the refactor/misc-improvements branch from 6a9693d to c68e2c7 Compare July 16, 2024 22:00
Base automatically changed from refactor/misc-improvements to master July 17, 2024 17:25
@glevco glevco merged commit b3f3d3e into master Jul 18, 2024
12 checks passed
@glevco glevco deleted the tests/side-dag branch July 18, 2024 16:30
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants