-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(side-dag): implement missing side-dag related tests #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 84.60% 85.04% +0.43%
==========================================
Files 309 309
Lines 23370 23396 +26
Branches 3523 3529 +6
==========================================
+ Hits 19772 19896 +124
+ Misses 2889 2799 -90
+ Partials 709 701 -8 ☔ View full report in Codecov by Sentry. |
054cb52
to
edf4ab4
Compare
msbrogli
previously approved these changes
Jun 13, 2024
jansegre
previously approved these changes
Jun 13, 2024
a750cbd
to
e543cbb
Compare
1 task
e543cbb
to
8d39404
Compare
8d39404
to
b525727
Compare
b525727
to
b85b855
Compare
The base branch was changed.
91ac26e
to
9274be7
Compare
eead7ac
to
6a9693d
Compare
6a9693d
to
c68e2c7
Compare
jansegre
approved these changes
Jul 17, 2024
msbrogli
approved these changes
Jul 18, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1069
Motivation
Implement missing tests for side-dag code.
Acceptance Criteria
PoaBlockProducer
so it does not require aHathorManager
for initialization, and update builders accordingly. Addmanager
calculated property.test_block.py
totest_poa.py
.test_poa_block_producer.py
andtest_poa_simulation.py
.test_verification.py
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged