fix(benchmark): fix CI on master #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Report | Wed, August 21, 2024 at 00:05:21 UTC |
| Project | hathor-core |
| Branch | fix/benchmark-ci |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,406,596,606.58 (-0.01%) | 81,129,754,896.65 (80.00%) | 121,694,632,344.98 (83.33%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
msbrogli
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1117 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 315 315
Lines 24071 24071
Branches 3647 3647
==========================================
- Hits 20425 20424 -1
- Misses 2930 2931 +1
Partials 716 716 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
fix/benchmark-ci
branch
from
e8f3aeb to
406db9c
Compare
jansegre
approved these changes
Aug 21, 2024
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #1112 introduced a regression in benchmark CI because it updated the PR workflow, but not the base branch workflow, and both should have been updated. This PR fixes it.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged