Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmark): fix CI on master #1121

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix(benchmark): fix CI on master #1121

merged 1 commit into from
Aug 21, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Aug 21, 2024

Motivation

PR #1117 attempted to fix the benchmark CI on master but it was still missing some configs. This PR fixes this, again.

Acceptance Criteria

  • Add config to prevent multiple benchmark CI actions from running concurrently.
  • Fix base benchmark workflow.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

🐰Bencher

ReportWed, August 21, 2024 at 02:07:13 UTC
Projecthathor-core
Branchfix/benchmark-ci
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,425,669,674.26 (-0.00%)81,141,793,548.21 (80.00%)121,712,690,322.32 (83.33%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (7ccc846) to head (2c3caa3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1121   +/-   ##
=======================================
  Coverage   84.88%   84.89%           
=======================================
  Files         315      315           
  Lines       24071    24071           
  Branches     3647     3647           
=======================================
+ Hits        20432    20434    +2     
+ Misses       2927     2925    -2     
  Partials      712      712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review August 21, 2024 02:54
@glevco glevco merged commit 7d3e1ec into master Aug 21, 2024
13 checks passed
@glevco glevco deleted the fix/benchmark-ci branch August 21, 2024 15:01
@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants