Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): reset event queue command #608

Merged
merged 3 commits into from
May 22, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 13, 2023

Acceptance Criteria

  • Implement --x-reset-event-queue CLI flag to reset the event queue, allowing the start of a full node without the event feature after it was previously enabled
  • Implement ability to reset all EventStorage data
  • Fix support for merged mining block

Closes #580

@glevco glevco self-assigned this May 13, 2023
@glevco glevco linked an issue May 13, 2023 that may be closed by this pull request
@glevco glevco changed the title Feat/reliable integration/reset queue feat(events): reset event queue command May 13, 2023
@glevco glevco marked this pull request as ready for review May 13, 2023 03:59
@glevco glevco requested review from jansegre and msbrogli as code owners May 13, 2023 03:59
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #608 (cbda38b) into master (d7508e0) will increase coverage by 0.00%.
The diff coverage is 81.81%.

@@           Coverage Diff           @@
##           master     #608   +/-   ##
=======================================
  Coverage   83.63%   83.64%           
=======================================
  Files         232      232           
  Lines       19826    19835    +9     
  Branches     2714     2714           
=======================================
+ Hits        16582    16591    +9     
  Misses       2644     2644           
  Partials      600      600           
Impacted Files Coverage Δ
hathor/manager.py 70.60% <0.00%> (-0.05%) ⬇️
hathor/builder/cli_builder.py 70.27% <40.00%> (-0.16%) ⬇️
hathor/event/event_manager.py 90.74% <100.00%> (ø)
hathor/event/model/event_data.py 100.00% <100.00%> (ø)
hathor/event/storage/event_storage.py 100.00% <100.00%> (ø)
hathor/event/storage/memory_storage.py 100.00% <100.00%> (ø)
hathor/event/storage/rocksdb_storage.py 94.18% <100.00%> (+0.28%) ⬆️

... and 2 files with indirect coverage changes

hathor/builder/cli_builder.py Show resolved Hide resolved
hathor/cli/run_node.py Outdated Show resolved Hide resolved
hathor/event/model/EventQueueOptions.py Outdated Show resolved Hide resolved
hathor/event/storage/event_storage.py Outdated Show resolved Hide resolved
hathor/event/storage/event_storage.py Outdated Show resolved Hide resolved
hathor/event/storage/rocksdb_storage.py Show resolved Hide resolved
@glevco glevco force-pushed the feat/reliable-integration-load branch from 10c380f to 75f3d66 Compare May 16, 2023 12:13
Base automatically changed from feat/reliable-integration-load to master May 16, 2023 16:23
@glevco glevco force-pushed the feat/reliable-integration/reset-queue branch 4 times, most recently from 79f2773 to 5dbc44e Compare May 18, 2023 20:53
@glevco glevco requested a review from msbrogli May 18, 2023 22:01
@glevco glevco force-pushed the feat/reliable-integration/reset-queue branch from 5dbc44e to cbda38b Compare May 19, 2023 19:40
@glevco glevco merged commit 5449ab6 into master May 22, 2023
@glevco glevco deleted the feat/reliable-integration/reset-queue branch May 22, 2023 18:12
@jansegre jansegre mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add reset event queue command
3 participants