Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send tips rate limit disconnect #650

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Jun 5, 2023

Fixes https://github.com/HathorNetwork/on-call-incidents/issues/123.

Acceptance Criteria

  • Cancel late calls to send_tips when peer disconnect

@alexruzenhack alexruzenhack self-assigned this Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #650 (695e0da) into master (de5267b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 695e0da differs from pull request most recent head fb2b1b2. Consider uploading reports for the commit fb2b1b2 to get more accurate results

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   84.04%   84.09%   +0.04%     
==========================================
  Files         245      245              
  Lines       20275    20291      +16     
  Branches     2756     2760       +4     
==========================================
+ Hits        17041    17064      +23     
+ Misses       2637     2631       -6     
+ Partials      597      596       -1     
Impacted Files Coverage Δ
hathor/p2p/node_sync.py 85.13% <100.00%> (-0.06%) ⬇️
hathor/simulator/simulator.py 94.64% <100.00%> (+0.06%) ⬆️

... and 15 files with indirect coverage changes

msbrogli
msbrogli previously approved these changes Jun 7, 2023
tests/p2p/test_sync_rate_limiter.py Outdated Show resolved Hide resolved
@alexruzenhack alexruzenhack force-pushed the fix/p2p-rate-limit-call-later branch from 695e0da to 0fd3d93 Compare June 7, 2023 20:29
jansegre
jansegre previously approved these changes Jun 7, 2023
@alexruzenhack alexruzenhack force-pushed the fix/p2p-rate-limit-call-later branch from 0fd3d93 to aadc565 Compare June 7, 2023 21:40
@alexruzenhack alexruzenhack dismissed stale reviews from jansegre and msbrogli via d905a6d June 7, 2023 21:48
@alexruzenhack alexruzenhack force-pushed the fix/p2p-rate-limit-call-later branch from aadc565 to d905a6d Compare June 7, 2023 21:48
msbrogli
msbrogli previously approved these changes Jun 7, 2023
jansegre
jansegre previously approved these changes Jun 7, 2023
hathor/p2p/node_sync.py Outdated Show resolved Hide resolved
- refactor: remove delayed call limit
- test: wrap _send_tips and assert _send_tips_call_later len
- test: verify delayed call is canceled
@alexruzenhack alexruzenhack force-pushed the fix/p2p-rate-limit-call-later branch from a453734 to fb2b1b2 Compare June 13, 2023 10:20
@alexruzenhack alexruzenhack merged commit 0dcf3b5 into master Jun 13, 2023
@alexruzenhack alexruzenhack deleted the fix/p2p-rate-limit-call-later branch June 13, 2023 16:45
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants