Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: p2p rate limit call later max limit #657

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

alexruzenhack
Copy link
Contributor

Acceptance criteria

  • Add a stop limit for the list of delayed calls

Related to: #650
Related to: https://github.com/HathorNetwork/on-call-incidents/issues/123

@alexruzenhack alexruzenhack self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #657 (e7868bf) into master (89a001c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head e7868bf differs from pull request most recent head 292550f. Consider uploading reports for the commit 292550f to get more accurate results

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   83.85%   83.80%   -0.06%     
==========================================
  Files         247      246       -1     
  Lines       20399    20323      -76     
  Branches     2757     2754       -3     
==========================================
- Hits        17106    17031      -75     
+ Misses       2712     2711       -1     
  Partials      581      581              
Impacted Files Coverage Δ
hathor/conf/settings.py 97.05% <100.00%> (+0.02%) ⬆️
hathor/p2p/node_sync.py 85.01% <100.00%> (-0.13%) ⬇️

... and 18 files with indirect coverage changes

@alexruzenhack alexruzenhack force-pushed the chore/p2p-rate-limit-call-later-limit branch 2 times, most recently from b9b3864 to b097029 Compare June 13, 2023 10:24
hathor/conf/settings.py Outdated Show resolved Hide resolved
tests/p2p/test_sync_rate_limiter.py Outdated Show resolved Hide resolved
@alexruzenhack alexruzenhack marked this pull request as ready for review June 13, 2023 16:49
@alexruzenhack alexruzenhack requested a review from jansegre as a code owner June 13, 2023 16:49
@alexruzenhack alexruzenhack force-pushed the chore/p2p-rate-limit-call-later-limit branch from b097029 to 47a4acb Compare June 13, 2023 19:52
@alexruzenhack alexruzenhack requested a review from msbrogli June 13, 2023 19:54
msbrogli
msbrogli previously approved these changes Jun 13, 2023
jansegre
jansegre previously approved these changes Jun 13, 2023
@alexruzenhack alexruzenhack force-pushed the chore/p2p-rate-limit-call-later-limit branch 2 times, most recently from 2f9d4ab to e7868bf Compare June 14, 2023 17:26
@alexruzenhack alexruzenhack enabled auto-merge June 14, 2023 17:26
@alexruzenhack alexruzenhack dismissed stale reviews from jansegre and msbrogli via c0efbc1 June 15, 2023 15:42
@alexruzenhack alexruzenhack force-pushed the chore/p2p-rate-limit-call-later-limit branch from e7868bf to c0efbc1 Compare June 15, 2023 15:42
@alexruzenhack alexruzenhack force-pushed the chore/p2p-rate-limit-call-later-limit branch from c0efbc1 to 292550f Compare June 15, 2023 16:06
@msbrogli msbrogli merged commit 292550f into master Jun 15, 2023
@msbrogli msbrogli deleted the chore/p2p-rate-limit-call-later-limit branch June 15, 2023 16:23
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants