Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve progress function #651

Merged
merged 4 commits into from
Jun 9, 2023
Merged

chore: improve progress function #651

merged 4 commits into from
Jun 9, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 5, 2023 •
edited
Loading

Acceptance Criteria

  • Move progress function from partial_rocksdb_tips_index.py to util.py, making it generic
  • Add ETA to progress function, solving TODO

@glevco glevco self-assigned this Jun 5, 2023
@glevco glevco changed the base branch from tests/event-simulation to master June 5, 2023 16:48
@glevco glevco force-pushed the chore/improve-progress branch from c4c450e to ef3520b Compare June 5, 2023 16:51
@glevco glevco added the enhancement New feature or request label Jun 5, 2023
@glevco glevco mentioned this pull request Jun 5, 2023
Merged
jansegre
jansegre previously approved these changes Jun 5, 2023
View reviewed changes
@glevco glevco requested a review from jansegre June 5, 2023 20:36
jansegre
jansegre previously approved these changes Jun 6, 2023
View reviewed changes
msbrogli
msbrogli previously approved these changes Jun 7, 2023
View reviewed changes
@glevco glevco marked this pull request as ready for review June 7, 2023 14:38
@glevco glevco force-pushed the chore/improve-progress branch from 2814a87 to 69151c0 Compare June 7, 2023 14:42
jansegre
jansegre reviewed Jun 7, 2023
View reviewed changes
hathor/util.py Outdated Show resolved Hide resolved
@glevco glevco dismissed stale reviews from jansegre and msbrogli via 7521949 June 7, 2023 15:24
@glevco glevco requested review from msbrogli and jansegre June 7, 2023 15:24
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #651 (7521949) into master (12ec328) will decrease coverage by 0.04%.
The diff coverage is 45.65%.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   84.08%   84.05%   -0.04%     
==========================================
  Files         245      245              
  Lines       20284    20286       +2     
  Branches     2757     2757              
==========================================
- Hits        17056    17051       -5     
- Misses       2632     2638       +6     
- Partials      596      597       +1
Impacted Files Coverage Δ
hathor/util.py 80.16% <41.86%> (-4.43%) ⬇️
hathor/indexes/manager.py 92.17% <100.00%> (ø)
hathor/indexes/partial_rocksdb_tips_index.py 76.71% <100.00%> (+9.11%) ⬆️

... and 1 file with indirect coverage changes

@glevco glevco merged commit 3ced4db into master Jun 9, 2023
@glevco glevco deleted the chore/improve-progress branch June 9, 2023 19:04
@jansegre jansegre mentioned this pull request Jul 12, 2023
Merged
2 tasks
This was referenced Aug 2, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansegre jansegre jansegre approved these changes

@msbrogli msbrogli msbrogli approved these changes

Assignees

@glevco glevco

Labels
enhancement New feature or request
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glevco @msbrogli @jansegre