Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve manager building on simulator #653

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 6, 2023

Acceptance Criteria

  • Implement Simulator.create_artifacts()
  • Change Simulator.create_peer() to receive a Builder, instead of receiving each builder argument and setting them
  • Provide new Simulator.get_default_builder() for convenience, keeping the previous default behavior
  • Add Builder.enable_full_verification() and Builder.disable_full_verification()

@glevco glevco self-assigned this Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #653 (6e96cae) into master (0cf0e1d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   84.06%   84.07%           
=======================================
  Files         245      245           
  Lines       20277    20284    +7     
  Branches     2758     2757    -1     
=======================================
+ Hits        17046    17053    +7     
+ Misses       2635     2633    -2     
- Partials      596      598    +2     
Impacted Files Coverage Δ
hathor/builder/builder.py 90.90% <100.00%> (+1.15%) ⬆️
hathor/simulator/simulator.py 94.57% <100.00%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

@glevco glevco marked this pull request as ready for review June 6, 2023 18:37
@glevco glevco requested review from jansegre and msbrogli as code owners June 6, 2023 18:37
@glevco glevco added the refactor label Jun 6, 2023
hathor/simulator/simulator.py Show resolved Hide resolved
@glevco glevco merged commit 12ec328 into master Jun 7, 2023
@glevco glevco deleted the refactor/simulator-builder branch June 7, 2023 14:29
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants