Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate set output #689

Merged
merged 4 commits into from
Jul 4, 2023
Merged

chore: deprecate set output #689

merged 4 commits into from
Jul 4, 2023

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Jul 3, 2023

Update the soon to be deprecated set-output command (reference)

@r4mmer r4mmer requested a review from luislhl July 3, 2023 15:18
@r4mmer r4mmer self-assigned this Jul 3, 2023
@r4mmer r4mmer requested review from jansegre and msbrogli as code owners July 3, 2023 15:18
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #689 (c911637) into master (56d9fb2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   84.09%   84.11%   +0.01%     
==========================================
  Files         246      246              
  Lines       20442    20442              
  Branches     2757     2757              
==========================================
+ Hits        17191    17195       +4     
+ Misses       2677     2674       -3     
+ Partials      574      573       -1     
Impacted Files Coverage Δ
hathor/conf/mainnet.py 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@r4mmer r4mmer force-pushed the chore/deprecate-set-output branch from c96b884 to c840f33 Compare July 3, 2023 18:53
@r4mmer r4mmer force-pushed the chore/deprecate-set-output branch from 77dc074 to c911637 Compare July 4, 2023 13:19
@r4mmer r4mmer merged commit e486924 into master Jul 4, 2023
@r4mmer r4mmer deleted the chore/deprecate-set-output branch July 4, 2023 14:46
@r4mmer r4mmer restored the chore/deprecate-set-output branch July 4, 2023 14:46
@r4mmer r4mmer deleted the chore/deprecate-set-output branch July 4, 2023 14:46
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants