Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate set output #689

Merged
merged 4 commits into from
Jul 4, 2023
Merged

chore: deprecate set output #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf8569c
chore: deprecate set output
r4mmer Jul 3, 2023
d958e31
chore: deprecate set-output on second workflow
r4mmer Jul 3, 2023
63697f1
chore: use append instead of push
r4mmer Jul 3, 2023
c911637
chore: use output file instead of environment variable
r4mmer Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ jobs:
matrix = full_matrix
else:
matrix = reduced_matrix
print('::set-output name=matrix::' + json.dumps(matrix))
with open(os.environ['GITHUB_OUTPUT'], 'a') as f:
f.write('matrix={}\n'.format(json.dumps(matrix)))
check-matrix:
runs-on: ubuntu-latest
needs: matrix
Expand Down
6 changes: 3 additions & 3 deletions extras/github/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
from typing import Dict

def print_output(output: Dict):
for k, v in output.items():
print(f'::set-output name={k}::{v}')

outputs = ['{}={}\n'.format(k, v) for k, v in output.items()]
with open(os.environ['GITHUB_OUTPUT'], 'a') as f:
f.writelines(outputs)

def prep_base_version(environ: Dict):
GITHUB_REF = environ.get('GITHUB_REF')
Expand Down