-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(daa): remove global daa test mode #802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2023
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
September 29, 2023 22:42
cf8df1d
to
75f9964
Compare
jansegre
previously approved these changes
Oct 6, 2023
glevco
force-pushed
the
refactor/simulator-patches/daa-settings
branch
from
October 10, 2023 03:03
09ee92f
to
c76fb12
Compare
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
October 10, 2023 03:09
75f9964
to
fd22533
Compare
glevco
force-pushed
the
refactor/simulator-patches/daa-settings
branch
2 times, most recently
from
November 3, 2023 18:45
d2f2993
to
22c4e78
Compare
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
November 3, 2023 18:52
fd22533
to
88c0162
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 85.11% 85.12% +0.01%
==========================================
Files 275 275
Lines 22514 22516 +2
Branches 3434 3434
==========================================
+ Hits 19162 19167 +5
+ Misses 2670 2667 -3
Partials 682 682
☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/simulator-patches/daa-settings
branch
from
November 3, 2023 21:08
22c4e78
to
2bcbc81
Compare
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
November 3, 2023 21:09
88c0162
to
3926fa5
Compare
Base automatically changed from
refactor/simulator-patches/daa-settings
to
master
November 3, 2023 21:11
msbrogli
approved these changes
Nov 3, 2023
jansegre
approved these changes
Nov 3, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #801
Motivation
This PR refactors the global daa
TEST_MODE
, allowing its simulator patch to be removed.Acceptance Criteria
daa.TEST_MODE
anddaa._set_test_mode()
, moving it to an attribute in the DAA class. Also, update respective usages.PeerId
class. It should be removed in a future PR._set_test_mode()
simulator patch.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged