-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cpu-mining): create CpuMiningService #803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
September 29, 2023 22:42
cf8df1d
to
75f9964
Compare
glevco
force-pushed
the
refactor/simulator-patches/cpu-mining-service
branch
3 times, most recently
from
September 29, 2023 22:58
4f8296a
to
0ae446e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 85.09% 85.05% -0.05%
==========================================
Files 275 276 +1
Lines 22516 22514 -2
Branches 3434 3430 -4
==========================================
- Hits 19161 19149 -12
- Misses 2672 2678 +6
- Partials 683 687 +4
☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
October 10, 2023 03:09
75f9964
to
fd22533
Compare
glevco
force-pushed
the
refactor/simulator-patches/cpu-mining-service
branch
2 times, most recently
from
October 10, 2023 03:35
0348cc0
to
dc7d9de
Compare
jansegre
previously approved these changes
Oct 10, 2023
msbrogli
previously approved these changes
Oct 18, 2023
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
November 3, 2023 18:52
fd22533
to
88c0162
Compare
glevco
force-pushed
the
refactor/simulator-patches/cpu-mining-service
branch
from
November 3, 2023 20:15
dc7d9de
to
639fd12
Compare
glevco
force-pushed
the
refactor/simulator-patches/daa-test-mode
branch
from
November 3, 2023 21:09
88c0162
to
3926fa5
Compare
glevco
force-pushed
the
refactor/simulator-patches/cpu-mining-service
branch
from
November 3, 2023 21:10
639fd12
to
0a780e9
Compare
Base automatically changed from
refactor/simulator-patches/daa-test-mode
to
master
November 3, 2023 22:34
glevco
dismissed stale reviews from msbrogli and jansegre
November 3, 2023 22:34
The base branch was changed.
glevco
force-pushed
the
refactor/simulator-patches/cpu-mining-service
branch
from
November 3, 2023 22:35
0a780e9
to
0ad3797
Compare
jansegre
previously approved these changes
Nov 3, 2023
glevco
force-pushed
the
refactor/simulator-patches/cpu-mining-service
branch
from
November 4, 2023 18:49
0ad3797
to
9cbb87e
Compare
jansegre
approved these changes
Nov 6, 2023
msbrogli
approved these changes
Nov 6, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #802
Motivation
This PR refactors the
BaseTransaction.resolve()
method, allowing its simulator patch to be removed.Acceptance Criteria
resolve()
andstart_mining()
methods fromBaseTransaction
and fromTokenCreationTransaction
, moving them to the newCpuMiningService
class. Code logic should not be changed, except for the addition of theTokenCreationTransaction
case.CpuMiningService
toHathorManager
, and updateBuilder
andCliBuilder
accordingly.simulator/verification.py
tosimulator/patches.py
, adding the newSimulatorCpuMiningService
class that overridesresolve()
.Simulator
, that now only uses injected customizations.resolve()
andstart_mining()
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged