Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor python healthcheck lib #826

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

luislhl
Copy link
Collaborator

@luislhl luislhl commented Oct 24, 2023

Motivation

Refactor the former healthcheck logic to use the new healthcheck lib we've built in https://github.com/HathorNetwork/python-healthcheck-lib

Acceptance Criteria

TODO

  • The lib is being installed directly from the Git repo to make sure we can test it. But we should install it from PyPI when it's available there.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@luislhl luislhl self-assigned this Oct 24, 2023
@luislhl luislhl force-pushed the chore/refactor-python-healthchecklib branch from 88843c2 to 5a564df Compare October 25, 2023 22:35
@luislhl luislhl force-pushed the chore/refactor-python-healthchecklib branch from 5a564df to 47228f3 Compare November 9, 2023 21:35
@luislhl luislhl marked this pull request as ready for review November 9, 2023 22:06
@luislhl luislhl requested a review from glevco November 9, 2023 22:06
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61327ba) 85.34% compared to head (be3539a) 85.29%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   85.34%   85.29%   -0.05%     
==========================================
  Files         283      282       -1     
  Lines       22331    22269      -62     
  Branches     3380     3365      -15     
==========================================
- Hits        19059    18995      -64     
- Misses       2597     2601       +4     
+ Partials      675      673       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

glevco
glevco previously approved these changes Nov 16, 2023
pyproject.toml Outdated Show resolved Hide resolved
glevco
glevco previously approved these changes Nov 27, 2023
jansegre
jansegre previously approved these changes Nov 28, 2023
poetry.lock Outdated Show resolved Hide resolved
@luislhl luislhl dismissed stale reviews from jansegre and glevco via f6e4609 November 29, 2023 18:30
@luislhl luislhl force-pushed the chore/refactor-python-healthchecklib branch from f6e4609 to 1482082 Compare November 29, 2023 18:40
jansegre
jansegre previously approved these changes Nov 29, 2023
@luislhl luislhl force-pushed the chore/refactor-python-healthchecklib branch from 1482082 to 898d24f Compare December 5, 2023 16:08
glevco
glevco previously approved these changes Dec 6, 2023
@luislhl luislhl force-pushed the chore/refactor-python-healthchecklib branch 2 times, most recently from e34c02a to ed2e432 Compare December 8, 2023 20:05
@luislhl luislhl force-pushed the chore/refactor-python-healthchecklib branch from ed2e432 to e4220e9 Compare December 11, 2023 18:43
@luislhl luislhl dismissed stale reviews from glevco and jansegre via be3539a December 12, 2023 00:09
@luislhl luislhl requested a review from glevco December 12, 2023 12:48
@luislhl luislhl merged commit 5526455 into master Dec 12, 2023
9 checks passed
@luislhl luislhl deleted the chore/refactor-python-healthchecklib branch December 12, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants