-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor python healthcheck lib #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislhl
force-pushed
the
chore/refactor-python-healthchecklib
branch
from
October 25, 2023 22:35
88843c2
to
5a564df
Compare
luislhl
force-pushed
the
chore/refactor-python-healthchecklib
branch
from
November 9, 2023 21:35
5a564df
to
47228f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
==========================================
- Coverage 85.34% 85.29% -0.05%
==========================================
Files 283 282 -1
Lines 22331 22269 -62
Branches 3380 3365 -15
==========================================
- Hits 19059 18995 -64
- Misses 2597 2601 +4
+ Partials 675 673 -2 ☔ View full report in Codecov by Sentry. |
glevco
previously approved these changes
Nov 16, 2023
glevco
previously approved these changes
Nov 27, 2023
jansegre
previously approved these changes
Nov 28, 2023
luislhl
force-pushed
the
chore/refactor-python-healthchecklib
branch
from
November 29, 2023 18:40
f6e4609
to
1482082
Compare
jansegre
previously approved these changes
Nov 29, 2023
luislhl
force-pushed
the
chore/refactor-python-healthchecklib
branch
from
December 5, 2023 16:08
1482082
to
898d24f
Compare
glevco
previously approved these changes
Dec 6, 2023
luislhl
force-pushed
the
chore/refactor-python-healthchecklib
branch
2 times, most recently
from
December 8, 2023 20:05
e34c02a
to
ed2e432
Compare
luislhl
force-pushed
the
chore/refactor-python-healthchecklib
branch
from
December 11, 2023 18:43
ed2e432
to
e4220e9
Compare
…ode from getting the event loop
jansegre
approved these changes
Dec 12, 2023
glevco
approved these changes
Dec 12, 2023
This was referenced Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor the former healthcheck logic to use the new healthcheck lib we've built in https://github.com/HathorNetwork/python-healthcheck-lib
Acceptance Criteria
TODO
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged