-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[healthcheck]: new health endpoint #807
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alexruzenhack
previously approved these changes
Oct 11, 2023
jansegre
reviewed
Oct 16, 2023
luislhl
force-pushed
the
feat/new-healthcheck-response-format
branch
from
October 16, 2023 21:16
5fd7560
to
a40ed33
Compare
luislhl
changed the base branch from
feat/healthcheck-get-best-blockchain
to
master
October 16, 2023 21:16
luislhl
force-pushed
the
feat/new-healthcheck-response-format
branch
from
October 16, 2023 21:57
84eb26d
to
131ccb9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
==========================================
- Coverage 84.53% 84.48% -0.05%
==========================================
Files 266 269 +3
Lines 22131 22223 +92
Branches 3380 3398 +18
==========================================
+ Hits 18708 18775 +67
- Misses 2757 2774 +17
- Partials 666 674 +8
☔ View full report in Codecov by Sentry. |
luislhl
commented
Oct 17, 2023
jansegre
previously approved these changes
Oct 17, 2023
jansegre
previously approved these changes
Oct 17, 2023
alexruzenhack
previously approved these changes
Oct 17, 2023
jansegre
approved these changes
Oct 17, 2023
alexruzenhack
approved these changes
Oct 17, 2023
luislhl
force-pushed
the
feat/new-healthcheck-response-format
branch
from
October 18, 2023 13:26
26b2650
to
52d742d
Compare
luislhl
force-pushed
the
feat/new-healthcheck-response-format
branch
from
October 18, 2023 18:40
52d742d
to
7962d44
Compare
luislhl
changed the title
feat[healthcheck]: new healthcheck response format
feat[healthcheck]: new health endpoint
Oct 19, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are building a new healthcheck standard
Acceptance Criteria
/health
endpoint that will check the health of the p2p sync and return our new health check formatstrict_status_code
query param in the request. It will make the endpoint return 200 even if there is a healthcheck failure.TODO
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged