Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[healthcheck]: new health endpoint #807

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

luislhl
Copy link
Collaborator

@luislhl luislhl commented Oct 6, 2023

Motivation

We are building a new healthcheck standard

Acceptance Criteria

  • Create a /health endpoint that will check the health of the p2p sync and return our new health check format
  • Allow changing the endpoint behavior regarding the status code it will return, by providing the strict_status_code query param in the request. It will make the endpoint return 200 even if there is a healthcheck failure.

TODO

  • Generate the new Nginx image

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

alexruzenhack
alexruzenhack previously approved these changes Oct 11, 2023
@luislhl luislhl force-pushed the feat/new-healthcheck-response-format branch from 5fd7560 to a40ed33 Compare October 16, 2023 21:16
@luislhl luislhl changed the base branch from feat/healthcheck-get-best-blockchain to master October 16, 2023 21:16
@luislhl luislhl dismissed alexruzenhack’s stale review October 16, 2023 21:16

The base branch was changed.

@luislhl luislhl force-pushed the feat/new-healthcheck-response-format branch from 84eb26d to 131ccb9 Compare October 16, 2023 21:57
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (4f2da10) 84.53% compared to head (7962d44) 84.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   84.53%   84.48%   -0.05%     
==========================================
  Files         266      269       +3     
  Lines       22131    22223      +92     
  Branches     3380     3398      +18     
==========================================
+ Hits        18708    18775      +67     
- Misses       2757     2774      +17     
- Partials      666      674       +8     
Files Coverage Δ
hathor/builder/resources_builder.py 94.44% <100.00%> (+0.05%) ⬆️
hathor/healthcheck/resources/__init__.py 100.00% <100.00%> (ø)
hathor/healthcheck/resources/healthcheck.py 100.00% <100.00%> (ø)
hathor/manager.py 80.95% <100.00%> (ø)
hathor/p2p/resources/healthcheck.py 68.75% <0.00%> (-31.25%) ⬇️
hathor/healthcheck/models.py 79.68% <79.68%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jansegre
jansegre previously approved these changes Oct 17, 2023
jansegre
jansegre previously approved these changes Oct 17, 2023
alexruzenhack
alexruzenhack previously approved these changes Oct 17, 2023
@luislhl luislhl dismissed stale reviews from alexruzenhack and jansegre via 26b2650 October 17, 2023 18:54
@luislhl luislhl force-pushed the feat/new-healthcheck-response-format branch from 26b2650 to 52d742d Compare October 18, 2023 13:26
@luislhl luislhl force-pushed the feat/new-healthcheck-response-format branch from 52d742d to 7962d44 Compare October 18, 2023 18:40
@luislhl luislhl merged commit f515f6d into master Oct 19, 2023
9 checks passed
@luislhl luislhl deleted the feat/new-healthcheck-response-format branch October 19, 2023 20:16
@luislhl luislhl changed the title feat[healthcheck]: new healthcheck response format feat[healthcheck]: new health endpoint Oct 19, 2023
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants