feat: support health-check endpoints on hathor-core and tx-mining-service #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #579 +/- ##
===========================================
+ Coverage 64.82% 78.51% +13.69%
===========================================
Files 67 68 +1
Lines 5257 5270 +13
Branches 1108 1108
===========================================
+ Hits 3408 4138 +730
+ Misses 1769 1117 -652
+ Partials 80 15 -65
☔ View full report in Codecov by Sentry. |
luislhl
commented
Oct 10, 2023
| */ | ||
| async getHealth() { | ||
| return new Promise((resolve, reject) => { | ||
| // TODO: We should chage this to get `health` instead of `version` |
There was a problem hiding this comment.
This depends on HathorNetwork/hathor-core#807
There was a problem hiding this comment.
This was merged a week ago. Has it been released already?
luislhl
changed the title
2 tasks
tuliomir
reviewed
Oct 20, 2023
luislhl
force-pushed
the
feat/health-check-support
branch
from
ddd34cf to
eaf26e5
Compare
tuliomir
reviewed
Oct 26, 2023
tuliomir
approved these changes
Oct 26, 2023
1 task
pedroferreira1
approved these changes
Oct 27, 2023
| */ | ||
| async getHealth() { | ||
| return new Promise((resolve, reject) => { | ||
| // TODO: We should chage this to get `health` instead of `version` |
There was a problem hiding this comment.
This was merged a week ago. Has it been released already?
luislhl
force-pushed
the
feat/health-check-support
branch
from
ea88727 to
ea5e749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Note: The health endpoint in hathor-core is still being developed in HathorNetwork/hathor-core#807. When it's released and available on most fullnodes, we will create a new PR to use it in the wallet-lib.
Security Checklist