Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feature-activation): add missing metadata migration #828

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 26, 2023

Motivation

During the latest release, we noticed that full node initialization could fail depending on the snapshot state (only on testnet). This was caused by a missing migration on the new Feature Activation metadata attribute.

Acceptance Criteria

  • Rename BitSignalingService.start() to generate_initial_logs() and add docstring. Also move call to after migrations are applied in HathorManager.
  • Implement add_feature_activation_bit_counts_metadata migration.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Oct 26, 2023
@glevco glevco self-assigned this Oct 26, 2023
@glevco glevco marked this pull request as ready for review October 26, 2023 21:41
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ab1a6ca) 84.63% compared to head (559d250) 84.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   84.63%   84.62%   -0.01%     
==========================================
  Files         270      271       +1     
  Lines       22290    22306      +16     
  Branches     3404     3406       +2     
==========================================
+ Hits        18865    18877      +12     
- Misses       2757     2762       +5     
+ Partials      668      667       -1     
Files Coverage Δ
hathor/feature_activation/bit_signaling_service.py 85.24% <ø> (ø)
hathor/manager.py 80.73% <100.00%> (ø)
hathor/transaction/storage/transaction_storage.py 93.17% <100.00%> (+0.12%) ⬆️
...ions/add_feature_activation_bit_counts_metadata.py 68.75% <68.75%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the fix/feature-activation/migration branch from 366e6ae to 559d250 Compare October 28, 2023 01:27
@glevco glevco merged commit ac435e0 into master Oct 28, 2023
9 checks passed
@glevco glevco deleted the fix/feature-activation/migration branch October 28, 2023 03:24
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants