-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): implement verify_minted_tokens [part 3/9] #832
Merged
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/3-verify-minted-tokens
Nov 23, 2023
Merged
refactor(verification): implement verify_minted_tokens [part 3/9] #832
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/3-verify-minted-tokens
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
changed the title
refactor(verification): implement verify_minted_tokens
refactor(verification): implement verify_minted_tokens [part 3/9]
Oct 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
==========================================
- Coverage 85.30% 85.30% -0.01%
==========================================
Files 281 281
Lines 22367 22365 -2
Branches 3388 3388
==========================================
- Hits 19080 19078 -2
+ Misses 2605 2603 -2
- Partials 682 684 +2 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 7, 2023 21:20
6811073
to
005adad
Compare
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
from
November 7, 2023 21:26
c5854de
to
a9a7081
Compare
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 7, 2023 21:31
005adad
to
84f38ae
Compare
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
from
November 7, 2023 21:31
a9a7081
to
da35c7d
Compare
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
4 times, most recently
from
November 10, 2023 15:22
2e709e9
to
dc55893
Compare
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
from
November 10, 2023 15:22
da35c7d
to
11a0131
Compare
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 10, 2023 16:31
dc55893
to
073d6f6
Compare
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
2 times, most recently
from
November 10, 2023 17:02
6309230
to
68a887d
Compare
glevco
changed the base branch from
refactor/verification-inheritance/2-verify-sum
to
refactor/move-token-info
November 10, 2023 17:02
glevco
force-pushed
the
refactor/move-token-info
branch
from
November 16, 2023 17:03
9857b55
to
50171eb
Compare
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
from
November 16, 2023 17:03
68a887d
to
4a9bd3e
Compare
glevco
force-pushed
the
refactor/move-token-info
branch
from
November 16, 2023 20:03
50171eb
to
5693c13
Compare
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
from
November 16, 2023 20:05
4a9bd3e
to
a4bbe0f
Compare
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
from
November 16, 2023 21:24
a4bbe0f
to
05498fa
Compare
msbrogli
approved these changes
Nov 23, 2023
jansegre
approved these changes
Nov 23, 2023
glevco
force-pushed
the
refactor/verification-inheritance/3-verify-minted-tokens
branch
from
November 23, 2023 20:14
05498fa
to
905d6bc
Compare
glevco
deleted the
refactor/verification-inheritance/3-verify-minted-tokens
branch
November 23, 2023 21:02
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #858
Motivation
Simplify
TokenCreationTransaction
verification to remove any calls tosuper()
, as it's not necessary.Acceptance Criteria
TokenCreationVerifier.verify_sum()
override, moving its only custom check to a newverify_minted_tokens()
, which is now explicitly called in theverify()
override.verify_minted_tokens()
totest_verification
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged