Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(verification): implement verify_minted_tokens [part 3/9] #832

Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 27, 2023

Depends on #858

Motivation

Simplify TokenCreationTransaction verification to remove any calls to super(), as it's not necessary.

Acceptance Criteria

  • Remove the TokenCreationVerifier.verify_sum() override, moving its only custom check to a new verify_minted_tokens(), which is now explicitly called in the verify() override.
  • Add verify_minted_tokens() to test_verification.
  • No behavior should be changed by this PR.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 27, 2023
@glevco glevco changed the title refactor(verification): implement verify_minted_tokens refactor(verification): implement verify_minted_tokens [part 3/9] Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa5109f) 85.30% compared to head (905d6bc) 85.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
- Coverage   85.30%   85.30%   -0.01%     
==========================================
  Files         281      281              
  Lines       22367    22365       -2     
  Branches     3388     3388              
==========================================
- Hits        19080    19078       -2     
+ Misses       2605     2603       -2     
- Partials      682      684       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/verification-inheritance/2-verify-sum branch from 6811073 to 005adad Compare November 7, 2023 21:20
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch from c5854de to a9a7081 Compare November 7, 2023 21:26
@glevco glevco force-pushed the refactor/verification-inheritance/2-verify-sum branch from 005adad to 84f38ae Compare November 7, 2023 21:31
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch from a9a7081 to da35c7d Compare November 7, 2023 21:31
@glevco glevco force-pushed the refactor/verification-inheritance/2-verify-sum branch 4 times, most recently from 2e709e9 to dc55893 Compare November 10, 2023 15:22
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch from da35c7d to 11a0131 Compare November 10, 2023 15:22
@glevco glevco force-pushed the refactor/verification-inheritance/2-verify-sum branch from dc55893 to 073d6f6 Compare November 10, 2023 16:31
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch 2 times, most recently from 6309230 to 68a887d Compare November 10, 2023 17:02
@glevco glevco changed the base branch from refactor/verification-inheritance/2-verify-sum to refactor/move-token-info November 10, 2023 17:02
@glevco glevco marked this pull request as ready for review November 10, 2023 20:07
@glevco glevco force-pushed the refactor/move-token-info branch from 9857b55 to 50171eb Compare November 16, 2023 17:03
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch from 68a887d to 4a9bd3e Compare November 16, 2023 17:03
@glevco glevco force-pushed the refactor/move-token-info branch from 50171eb to 5693c13 Compare November 16, 2023 20:03
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch from 4a9bd3e to a4bbe0f Compare November 16, 2023 20:05
Base automatically changed from refactor/move-token-info to master November 16, 2023 21:21
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch from a4bbe0f to 05498fa Compare November 16, 2023 21:24
@glevco glevco force-pushed the refactor/verification-inheritance/3-verify-minted-tokens branch from 05498fa to 905d6bc Compare November 23, 2023 20:14
@glevco glevco merged commit 448a560 into master Nov 23, 2023
9 checks passed
@glevco glevco deleted the refactor/verification-inheritance/3-verify-minted-tokens branch November 23, 2023 21:02
@jansegre jansegre mentioned this pull request Nov 24, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants